third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp - Issue 1714663002: Attempt to fix the crash in blink Scroll Animator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 1714663002: Attempt to fix the crash in blink Scroll Animator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: undo scroll animator mac changes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

index f91bc0ff01e9bbcd0b41e2c11f60264744ee9243..84137e6a7f1bffae0a73b2f14f45518666af58f0 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

@@ -95,6 +95,8 @@ ScrollableArea::~ScrollableArea()

void ScrollableArea::clearScrollAnimators()

{

#if OS(MACOSX) && ENABLE(OILPAN)

+ // TODO(ymalik): Let oilpan decide when to call dispose rather than

+ // explicitly calling it here to cleanup.

if (m_scrollAnimator)

m_scrollAnimator->dispose();

#endif

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »