Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: media/base/audio_block_fifo.h

Issue 1714593003: Introduce media::AudioPushFifo and a couple of use cases (and clean-ups). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Win compile issue. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_block_fifo.h
diff --git a/media/base/audio_block_fifo.h b/media/base/audio_block_fifo.h
index a90a3dfe65661a3b089f517703c53d9de6c18f78..8da932dffa6bc7a87fb682e08fb67c9623835ef0 100644
--- a/media/base/audio_block_fifo.h
+++ b/media/base/audio_block_fifo.h
@@ -17,6 +17,9 @@ namespace media {
// data as input and will deinterleave it into the FIFO, and it only allows
// consuming a whole block of AudioBus element.
// This class is thread-unsafe.
+//
DaleCurtis 2016/02/20 00:07:22 Do you plan to port and remove existing instances?
miu 2016/02/23 04:27:41 I don't have the available cycles, myself. I've r
+// NOTE: Consider using the more-efficient and easier-to-use AudioRechunker
+// instead of this FIFO implementation.
class MEDIA_EXPORT AudioBlockFifo {
public:
// Creates a new AudioBlockFifo and allocates |blocks| memory, each block

Powered by Google App Engine
This is Rietveld 408576698