Refactoring: Remove DETAILED_MEMORY_INFRA

third_party/WebKit/Source/platform/heap/ThreadState.cpp

Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index ba95db76feddaf97e8bc640c2959b2285c123e41..41bec8bcc23d23f899cdc803da1af86b37f8cb05 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -1479,10 +1479,8 @@ void ThreadState::takeSnapshot(SnapshotType type)
     size_t totalLiveSize = 0;
     size_t totalDeadSize = 0;
     for (size_t gcInfoIndex = 1; gcInfoIndex <= GCInfoTable::gcInfoIndex(); ++gcInfoIndex) {

[Primiano Tucci (use gerrit), 2016/02/19 10:04:51]

I wonder (for a next followup cl, not this one): if we know that we don't have
class-names, is it worth spamming the regular dumps with stuff like this?

https://imgur.com/n37JVaR

[hajimehoshi, 2016/02/19 10:32:03]

Hmm, this CL doesn't affect if the output is spammed, right? I don't think this
CL changed the dump names (except for type names).

[Primiano Tucci (use gerrit), 2016/02/19 11:11:52]

Right. I am just saying that now that we have the heap profiler, having a second
copy of the class list in the standard dump might be superfluous? WDYT?
In any case, nothing that belongs to this CL.

-        String dumpName = classesDumpName + String::format("/%lu_", static_cast<unsigned long>(gcInfoIndex));
-#if ENABLE(DETAILED_MEMORY_INFRA)
-        dumpName.append(Heap::gcInfo(gcInfoIndex)->className());
-#endif
+        const char* className = Heap::gcInfo(gcInfoIndex)->className();
+        String dumpName = classesDumpName + String::format("/%lu_%s", static_cast<unsigned long>(gcInfoIndex), className ? className : "");
         WebMemoryAllocatorDump* classDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(dumpName);
         classDump->addScalar("live_count", "objects", info.liveCount[gcInfoIndex]);
         classDump->addScalar("dead_count", "objects", info.deadCount[gcInfoIndex]);