Refactoring: Remove DETAILED_MEMORY_INFRA

third_party/WebKit/Source/platform/heap/ThreadState.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1460 matching lines @@
 
 #undef SNAPSHOT_HEAP
 
     if (type == SnapshotType::FreelistSnapshot)
         return;
 
     size_t totalLiveCount = 0;
     size_t totalDeadCount = 0;
     size_t totalLiveSize = 0;
     size_t totalDeadSize = 0;
     for (size_t gcInfoIndex = 1; gcInfoIndex <= GCInfoTable::gcInfoIndex(); ++gcInfoIndex) {

[Primiano Tucci (use gerrit), 2016/02/19 11:58:04]

I think you want to remove this for loop entirely (line 1481-1494) and just keep
the per-heap stats ?

This is going to output a row for each class, but just print out numeric IDs for
them like this: https://imgur.com/n37JVaR
which I am not sure if they are really useful.
What does tell you if if threadX/classes/101 is using X size?

[hajimehoshi, 2016/02/19 12:15:44]

I was thinking I'll remove this later, but you are right, I can remove this
logic now. However, this loop is needed to calculate the total live/dead
count/size. Done

[haraken, 2016/02/19 12:19:39]

BTW, if we remove the loop, won't we lose the information about liveCount,
deadCount, liveSize and deadSize per object type?

Sorry for getting you back and forth, but I begin to think that we need the
information per object type and thus we still need GCInfo::m_classname (to print
a meaningful name here).

GCInfo::m_classname is "" by default and stores a class name when
--enable-heap-profiling is specified.

(Correct me if I'm wrong.)

-        String dumpName = classesDumpName + String::format("/%lu_", static_cast<unsigned long>(gcInfoIndex));
-#if ENABLE(DETAILED_MEMORY_INFRA)
-        dumpName.append(Heap::gcInfo(gcInfoIndex)->className());
-#endif
+        String dumpName = classesDumpName + String::format("/%lu", static_cast<unsigned long>(gcInfoIndex));
         WebMemoryAllocatorDump* classDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(dumpName);
         classDump->addScalar("live_count", "objects", info.liveCount[gcInfoIndex]);
         classDump->addScalar("dead_count", "objects", info.deadCount[gcInfoIndex]);
         classDump->addScalar("live_size", "bytes", info.liveSize[gcInfoIndex]);
         classDump->addScalar("dead_size", "bytes", info.deadSize[gcInfoIndex]);
 
         totalLiveCount += info.liveCount[gcInfoIndex];
         totalDeadCount += info.deadCount[gcInfoIndex];
         totalLiveSize += info.liveSize[gcInfoIndex];
         totalDeadSize += info.deadSize[gcInfoIndex];
     }
 
     WebMemoryAllocatorDump* threadDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(threadDumpName);
     threadDump->addScalar("live_count", "objects", totalLiveCount);
     threadDump->addScalar("dead_count", "objects", totalDeadCount);
     threadDump->addScalar("live_size", "bytes", totalLiveSize);
     threadDump->addScalar("dead_size", "bytes", totalDeadSize);
 
     WebMemoryAllocatorDump* heapsDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(heapsDumpName);
     WebMemoryAllocatorDump* classesDump = BlinkGCMemoryDumpProvider::instance()->createMemoryAllocatorDumpForCurrentGC(classesDumpName);
     BlinkGCMemoryDumpProvider::instance()->currentProcessMemoryDump()->addOwnershipEdge(classesDump->guid(), heapsDump->guid());
 }
 
 } // namespace blink