third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 1714523005: WIP: backface visibility plumbing (not for review)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 1714523005: WIP: backface visibility plumbing (not for review) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: still broken Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index 6592c1a1350ec5712ef63ede8d17cd2e32654fcf..061be130660c1f36d90163de32d2ad7f5bcd4042 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -274,6 +274,7 @@ void PaintArtifactCompositor::update(const PaintArtifact& paintArtifact)

layer->SetBounds(combinedBounds.size());

layer->SetTransform(transform);

layer->SetIsDrawable(true);

+ layer->SetDoubleSided(!paintChunk.properties.backfaceHidden);

if (paintChunk.knownToBeOpaque)

layer->SetContentsOpaque(true);

layer->SetNeedsDisplay();