Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: src/compiler/x87/code-generator-x87.cc

Issue 1714513003: [turbofan] Fix write barrier handling of map values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add arm64 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | test/mjsunit/regress-587004.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 operand_(operand), 239 operand_(operand),
240 value_(value), 240 value_(value),
241 scratch0_(scratch0), 241 scratch0_(scratch0),
242 scratch1_(scratch1), 242 scratch1_(scratch1),
243 mode_(mode) {} 243 mode_(mode) {}
244 244
245 void Generate() final { 245 void Generate() final {
246 if (mode_ > RecordWriteMode::kValueIsPointer) { 246 if (mode_ > RecordWriteMode::kValueIsPointer) {
247 __ JumpIfSmi(value_, exit()); 247 __ JumpIfSmi(value_, exit());
248 } 248 }
249 if (mode_ > RecordWriteMode::kValueIsMap) { 249 __ CheckPageFlag(value_, scratch0_,
250 __ CheckPageFlag(value_, scratch0_, 250 MemoryChunk::kPointersToHereAreInterestingMask, zero,
251 MemoryChunk::kPointersToHereAreInterestingMask, zero, 251 exit());
252 exit());
253 }
254 SaveFPRegsMode const save_fp_mode = 252 SaveFPRegsMode const save_fp_mode =
255 frame()->DidAllocateDoubleRegisters() ? kSaveFPRegs : kDontSaveFPRegs; 253 frame()->DidAllocateDoubleRegisters() ? kSaveFPRegs : kDontSaveFPRegs;
256 RecordWriteStub stub(isolate(), object_, scratch0_, scratch1_, 254 RecordWriteStub stub(isolate(), object_, scratch0_, scratch1_,
257 EMIT_REMEMBERED_SET, save_fp_mode); 255 EMIT_REMEMBERED_SET, save_fp_mode);
258 __ lea(scratch1_, operand_); 256 __ lea(scratch1_, operand_);
259 __ CallStub(&stub); 257 __ CallStub(&stub);
260 } 258 }
261 259
262 private: 260 private:
263 Register const object_; 261 Register const object_;
(...skipping 1965 matching lines...) Expand 10 before | Expand all | Expand 10 after
2229 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2227 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2230 __ Nop(padding_size); 2228 __ Nop(padding_size);
2231 } 2229 }
2232 } 2230 }
2233 2231
2234 #undef __ 2232 #undef __
2235 2233
2236 } // namespace compiler 2234 } // namespace compiler
2237 } // namespace internal 2235 } // namespace internal
2238 } // namespace v8 2236 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | test/mjsunit/regress-587004.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698