Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: src/compiler/ppc/code-generator-ppc.cc

Issue 1714513003: [turbofan] Fix write barrier handling of map values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add arm64 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 offset_immediate_(offset), 182 offset_immediate_(offset),
183 value_(value), 183 value_(value),
184 scratch0_(scratch0), 184 scratch0_(scratch0),
185 scratch1_(scratch1), 185 scratch1_(scratch1),
186 mode_(mode) {} 186 mode_(mode) {}
187 187
188 void Generate() final { 188 void Generate() final {
189 if (mode_ > RecordWriteMode::kValueIsPointer) { 189 if (mode_ > RecordWriteMode::kValueIsPointer) {
190 __ JumpIfSmi(value_, exit()); 190 __ JumpIfSmi(value_, exit());
191 } 191 }
192 if (mode_ > RecordWriteMode::kValueIsMap) { 192 __ CheckPageFlag(value_, scratch0_,
193 __ CheckPageFlag(value_, scratch0_, 193 MemoryChunk::kPointersToHereAreInterestingMask, eq,
194 MemoryChunk::kPointersToHereAreInterestingMask, eq, 194 exit());
195 exit());
196 }
197 SaveFPRegsMode const save_fp_mode = 195 SaveFPRegsMode const save_fp_mode =
198 frame()->DidAllocateDoubleRegisters() ? kSaveFPRegs : kDontSaveFPRegs; 196 frame()->DidAllocateDoubleRegisters() ? kSaveFPRegs : kDontSaveFPRegs;
199 if (!frame()->needs_frame()) { 197 if (!frame()->needs_frame()) {
200 // We need to save and restore lr if the frame was elided. 198 // We need to save and restore lr if the frame was elided.
201 __ mflr(scratch1_); 199 __ mflr(scratch1_);
202 __ Push(scratch1_); 200 __ Push(scratch1_);
203 } 201 }
204 RecordWriteStub stub(isolate(), object_, scratch0_, scratch1_, 202 RecordWriteStub stub(isolate(), object_, scratch0_, scratch1_,
205 EMIT_REMEMBERED_SET, save_fp_mode); 203 EMIT_REMEMBERED_SET, save_fp_mode);
206 if (offset_.is(no_reg)) { 204 if (offset_.is(no_reg)) {
(...skipping 1699 matching lines...) Expand 10 before | Expand all | Expand 10 after
1906 padding_size -= v8::internal::Assembler::kInstrSize; 1904 padding_size -= v8::internal::Assembler::kInstrSize;
1907 } 1905 }
1908 } 1906 }
1909 } 1907 }
1910 1908
1911 #undef __ 1909 #undef __
1912 1910
1913 } // namespace compiler 1911 } // namespace compiler
1914 } // namespace internal 1912 } // namespace internal
1915 } // namespace v8 1913 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698