Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1714513003: [turbofan] Fix write barrier handling of map values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add arm64 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/ia32/code-generator-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/arm64/macro-assembler-arm64.h" 8 #include "src/arm64/macro-assembler-arm64.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/compiler/code-generator-impl.h" 10 #include "src/compiler/code-generator-impl.h"
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 index_(index), 278 index_(index),
279 value_(value), 279 value_(value),
280 scratch0_(scratch0), 280 scratch0_(scratch0),
281 scratch1_(scratch1), 281 scratch1_(scratch1),
282 mode_(mode) {} 282 mode_(mode) {}
283 283
284 void Generate() final { 284 void Generate() final {
285 if (mode_ > RecordWriteMode::kValueIsPointer) { 285 if (mode_ > RecordWriteMode::kValueIsPointer) {
286 __ JumpIfSmi(value_, exit()); 286 __ JumpIfSmi(value_, exit());
287 } 287 }
288 if (mode_ > RecordWriteMode::kValueIsMap) { 288 __ CheckPageFlagClear(value_, scratch0_,
289 __ CheckPageFlagClear(value_, scratch0_, 289 MemoryChunk::kPointersToHereAreInterestingMask,
290 MemoryChunk::kPointersToHereAreInterestingMask, 290 exit());
291 exit());
292 }
293 SaveFPRegsMode const save_fp_mode = 291 SaveFPRegsMode const save_fp_mode =
294 frame()->DidAllocateDoubleRegisters() ? kSaveFPRegs : kDontSaveFPRegs; 292 frame()->DidAllocateDoubleRegisters() ? kSaveFPRegs : kDontSaveFPRegs;
295 if (!frame()->needs_frame()) { 293 if (!frame()->needs_frame()) {
296 // We need to save and restore lr if the frame was elided. 294 // We need to save and restore lr if the frame was elided.
297 __ Push(lr); 295 __ Push(lr);
298 } 296 }
299 RecordWriteStub stub(isolate(), object_, scratch0_, scratch1_, 297 RecordWriteStub stub(isolate(), object_, scratch0_, scratch1_,
300 EMIT_REMEMBERED_SET, save_fp_mode); 298 EMIT_REMEMBERED_SET, save_fp_mode);
301 __ Add(scratch1_, object_, index_); 299 __ Add(scratch1_, object_, index_);
302 __ CallStub(&stub); 300 __ CallStub(&stub);
(...skipping 1421 matching lines...) Expand 10 before | Expand all | Expand 10 after
1724 padding_size -= kInstructionSize; 1722 padding_size -= kInstructionSize;
1725 } 1723 }
1726 } 1724 }
1727 } 1725 }
1728 1726
1729 #undef __ 1727 #undef __
1730 1728
1731 } // namespace compiler 1729 } // namespace compiler
1732 } // namespace internal 1730 } // namespace internal
1733 } // namespace v8 1731 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/ia32/code-generator-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698