Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1714463002: Compare variable initializers as functions, skip the return type. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/resynthesize.dart
diff --git a/pkg/analyzer/lib/src/summary/resynthesize.dart b/pkg/analyzer/lib/src/summary/resynthesize.dart
index be97bfb0d091b1169d926c789a362dbf04581183..f333826b7a384291a422eaeeeaed76669587e4f1 100644
--- a/pkg/analyzer/lib/src/summary/resynthesize.dart
+++ b/pkg/analyzer/lib/src/summary/resynthesize.dart
@@ -1764,6 +1764,11 @@ class _LibraryResynthesizer {
}
FunctionElementImpl initializerElement =
buildLocalFunction(serializedInitializer);
+ // TODO(scheglov) The flag `hasImplicitReturnType` is `true` now because we
Paul Berry 2016/02/18 16:40:00 FYI, I'm about to make a change to the element mod
+ // don't serialize the return type. But once we do, the next two statements
+ // can be removed.
+ assert(initializerElement.hasImplicitReturnType == true);
+ initializerElement.hasImplicitReturnType = false;
initializerElement.synthetic = true;
variable.initializer = initializerElement;
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698