Android: Record metrics for buttons in the Origin Info Bubble

Android: Record metrics for buttons in the Origin Info Bubble

WebsiteSettings records metrics for a variety of user actions, however,
most of these were not being recorded correctly on Android. This adds
the histogram metrics to buttons in the Android WebsiteSettingsPopup
using the existing native recording method.

BUG=587635
Committed: https://crrev.com/7679a4df45cb846fdc5ee42fb67e973f6197d780
Cr-Commit-Position: refs/heads/master@{#376883}

[tsergeant, 2016-02-22 02:57:08]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 02:57:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714383002/1

[commit-bot: I haz the power, 2016-02-22 03:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 03:37:45]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-02-22 05:54:20]

tsergeant@chromium.org changed reviewers:
+ tedchoc@chromium.org

[tsergeant, 2016-02-22 05:54:21]

tedchoc@, please take a look.

[Ted C, 2016-02-22 18:26:51]

lgtm

https://codereview.chromium.org/1714383002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/1714383002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:83:
WEBSITE_SETTINGS_OPENED = 0,
Should we log this in from showDialog?

[tsergeant, 2016-02-23 00:24:52]

tsergeant@chromium.org changed reviewers:
+ thestig@chromium.org

[tsergeant, 2016-02-23 00:24:52]

+thestig@ for chrome/BUILD.gn, chrome/chrome.gyp and the small change to
chrome/browser/ui/website_settings/website_settings.h

https://codereview.chromium.org/1714383002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.h (right):

https://codereview.chromium.org/1714383002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.h:83:
WEBSITE_SETTINGS_OPENED = 0,
On 2016/02/22 18:26:51, Ted C wrote:
> Should we log this in from showDialog?

It already gets logged in the constructor for WebsiteSettings, which is a common
codepath for desktop and Android.

[Lei Zhang, 2016-02-23 00:40:10]

lgtm

[tsergeant, 2016-02-23 00:48:03]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-02-23 00:49:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714383002/1

[commit-bot: I haz the power, 2016-02-23 01:00:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-23 01:01:52]

Description was changed from

==========
Android: Record metrics for buttons in the Origin Info Bubble

WebsiteSettings records metrics for a variety of user actions, however,
most of these were not being recorded correctly on Android. This adds
the histogram metrics to buttons in the Android WebsiteSettingsPopup
using the existing native recording method.

BUG=587635
==========

to

==========
Android: Record metrics for buttons in the Origin Info Bubble

WebsiteSettings records metrics for a variety of user actions, however,
most of these were not being recorded correctly on Android. This adds
the histogram metrics to buttons in the Android WebsiteSettingsPopup
using the existing native recording method.

BUG=587635

Committed: https://crrev.com/7679a4df45cb846fdc5ee42fb67e973f6197d780
Cr-Commit-Position: refs/heads/master@{#376883}
==========

[commit-bot: I haz the power, 2016-02-23 01:01:53]

Patchset 1 (id:??) landed as
https://crrev.com/7679a4df45cb846fdc5ee42fb67e973f6197d780
Cr-Commit-Position: refs/heads/master@{#376883}