Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Issue 17143008: Enable all tryserver tests even when not production master. (Closed)

Created:
7 years, 6 months ago by Mike Stip (use stip instead)
Modified:
7 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Enable all tryserver tests even when not production master. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=207987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
iannucci
lgtm Ew... is there something we can do to detect this sort of thing in ...
7 years, 6 months ago (2013-06-22 01:33:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/17143008/1
7 years, 6 months ago (2013-06-22 01:33:09 UTC) #2
commit-bot: I haz the power
Change committed as 207987
7 years, 6 months ago (2013-06-22 01:33:26 UTC) #3
M-A Ruel
On 2013/06/22 01:33:02, iannucci wrote: > lgtm > > Ew... is there something we can ...
7 years, 5 months ago (2013-07-09 15:36:08 UTC) #4
iannucci
On 2013/07/09 15:36:08, Marc-Antoine Ruel wrote: > On 2013/06/22 01:33:02, iannucci wrote: > > lgtm ...
7 years, 5 months ago (2013-07-09 16:55:29 UTC) #5
M-A Ruel
> Hardcoding a list of tests which is dependent on the detected hostname of the ...
7 years, 5 months ago (2013-07-09 17:03:29 UTC) #6
Mike Stip (use stip instead)
7 years, 5 months ago (2013-07-09 18:20:49 UTC) #7
Message was sent while issue was closed.
This completely breaks buildrunner and all build scanning tools. We need to
limit is_production_host as much as possible.

Powered by Google App Engine
This is Rietveld 408576698