Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 17143003: Rewrite SVG viewspec tests to not be fuzzer tests. (Closed)

Created:
7 years, 6 months ago by pdr.
Modified:
7 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Rewrite SVG viewspec tests to not be fuzzer tests. This patch adds five new tests for invalid viewspec values and removes the flaky and slow viewspec parser fuzzer tests. See the viewspec spec for more information about the values tested here: https://svgwg.org/svg2-draft/single-page.html#linking-SVGFragmentIdentifiers Note: We do not support viewTarget or zoomAndPan so these values are just checked for parsing correctness and not behavior. The other values (viewBox, preserveAspectRatio, and transform) are actually tested to work. BUG=249578 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152522

Patch Set 1 #

Patch Set 2 : Update for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -1394 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +1 line, -13 lines 0 comments Download
A LayoutTests/svg/dom/resources/viewspec-aspectparams.svg View Binary file 0 comments Download
D LayoutTests/svg/dom/resources/viewspec-parser.js View 1 chunk +0 lines, -121 lines 0 comments Download
A LayoutTests/svg/dom/resources/viewspec-transformparams.svg View Binary file 0 comments Download
A LayoutTests/svg/dom/resources/viewspec-viewboxparams.svg View Binary file 0 comments Download
A LayoutTests/svg/dom/resources/viewspec-viewtargetparams.svg View Binary file 0 comments Download
A LayoutTests/svg/dom/resources/viewspec-zoomandpanparams.svg View Binary file 0 comments Download
A LayoutTests/svg/dom/viewspec-aspectparams.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-aspectparams-expected.html View 1 chunk +17 lines, -0 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-1.html View 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-1-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-2.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-2-expected.txt View 1 chunk +0 lines, -87 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-3.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-3-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-4.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-4-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-5.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-5-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-6.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-6-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-7.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/svg/dom/viewspec-parser-7-expected.txt View 1 chunk +0 lines, -162 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-transformparams.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-transformparams-expected.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-viewboxparams.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-viewboxparams-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-viewtargetparams.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-viewtargetparams-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-zoomandpanparams.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/viewspec-zoomandpanparams-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
7 years, 6 months ago (2013-06-15 05:06:52 UTC) #1
ojan
lgtm YES!
7 years, 6 months ago (2013-06-15 17:33:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/17143003/1
7 years, 6 months ago (2013-06-15 17:34:02 UTC) #3
commit-bot: I haz the power
Can't process patch for file LayoutTests/svg/dom/resources/viewspec-aspectparams.svg. Binary file support is temporarilly disabled due to a ...
7 years, 6 months ago (2013-06-15 17:34:05 UTC) #4
pdr.
7 years, 6 months ago (2013-06-17 06:09:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r152522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698