Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 1714233002: [MD settings] removing unused imports from bluetooth, startup and privacy settings (Closed)

Created:
4 years, 10 months ago by dschuyler
Modified:
4 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] removing unused imports from blutooth, startup and privacy settings This CL removes some unused imports under the idea that it's better to not import things that are not needed. This also cleans up a couple TODO comments. BUG=531750 Committed: https://crrev.com/46b4db154a6fa8f7bb1550ed17c490e4db5a4881 Cr-Commit-Position: refs/heads/master@{#377130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dschuyler
4 years, 10 months ago (2016-02-20 00:06:16 UTC) #3
stevenjb
lgtm
4 years, 10 months ago (2016-02-23 22:22:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714233002/1
4 years, 10 months ago (2016-02-23 22:27:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 23:42:47 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 23:44:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46b4db154a6fa8f7bb1550ed17c490e4db5a4881
Cr-Commit-Position: refs/heads/master@{#377130}

Powered by Google App Engine
This is Rietveld 408576698