tools/push-to-trunk/auto_roll.py - Issue 171423013: Refactoring: Extract low-level git from push and merge scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/push-to-trunk/auto_roll.py

Issue 171423013: Refactoring: Extract low-level git from push and merge scripts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Correct copyright year. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/push-to-trunk/auto_roll.py

diff --git a/tools/push-to-trunk/auto_roll.py b/tools/push-to-trunk/auto_roll.py

index f439cf57c36435ae2998dce8550713cf89d9c68f..fc50afb32f00ac6de4ee1ef763837601e7b88804 100755

--- a/tools/push-to-trunk/auto_roll.py

+++ b/tools/push-to-trunk/auto_roll.py

@@ -93,8 +93,7 @@ class FetchLatestRevision(Step):

MESSAGE = "Fetching latest V8 revision."

def RunStep(self):

- log = self.Git("svn log -1 --oneline").strip()

- match = re.match(r"^r(\d+) ", log)

+ match = re.match(r"^r(\d+) ", self.GitSVNLog())

if not match:

self.Die("Could not extract current svn revision from log.")

self["latest"] = match.group(1)

@@ -105,7 +104,7 @@ class CheckLastPush(Step):

def RunStep(self):

last_push_hash = self.FindLastTrunkPush()

- last_push = int(self.Git("svn find-rev %s" % last_push_hash).strip())

+ last_push = int(self.GitSVNFindSVNRev(last_push_hash))

# TODO(machenbach): This metric counts all revisions. It could be

# improved by counting only the revisions on bleeding_edge.

« no previous file with comments | « no previous file | tools/push-to-trunk/common_includes.py » ('j') | no next file with comments »