Issue 171423013: Refactoring: Extract low-level git from push and merge scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171423013: Refactoring: Extract low-level git from push and merge scripts. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactoring: Extract low-level git from push and merge scripts. - This adds a python layer on top of the low-level git calls to control parameter passing and return values. - This also fixes a bug in FindLastTrunkPush that only shows up in manual mode when the last push versions are iterated. - The order of some parameters changed in some git calls in the tests to be uniform. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19515

Patch Set 1 : #

Patch Set 2 : Correct copyright year. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -159 lines)			Patch
M	tools/push-to-trunk/auto_roll.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View		6 chunks	+21 lines, -33 lines	0 comments	Download
A	tools/push-to-trunk/git_recipes.py	View	1	1 chunk	+161 lines, -0 lines	0 comments	Download
M	tools/push-to-trunk/merge_to_branch.py	View		8 chunks	+22 lines, -25 lines	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View		16 chunks	+43 lines, -53 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View		5 chunks	+45 lines, -45 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 10 months ago (2014-02-20 16:39:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19515 (presubmit successful).

Expand Messages | Collapse Messages