Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5417)

Unified Diff: chrome/browser/about_flags.cc

Issue 171423005: Added in-session captive portal notification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 65e8c500d5e893fb1ec2fc08dc7d09d063af616f..7053fac16474918dfd9d28e266be63314a7de894 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -335,6 +335,16 @@ const Experiment::Choice kZeroSuggestExperimentsChoices[] = {
};
#endif
+#if defined(OS_CHROMEOS)
+const Experiment::Choice kNetworkPortalNotificationChoices[] = {
Jun Mukai 2014/02/19 19:17:25 Instead of declaring this, isn't it sufficient to
ygorshenin1 2014/02/20 16:31:39 Done.
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ chromeos::switches::kEnableNetworkPortalNotification, "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ chromeos::switches::kDisableNetworkPortalNotification, "" }
+};
+#endif
+
const Experiment::Choice kNumRasterThreadsChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_NUM_RASTER_THREADS_ONE, switches::kNumRasterThreads, "1" },
@@ -1033,6 +1043,13 @@ const Experiment kExperiments[] = {
ash::switches::kAshEnableImmersiveFullscreenForAllWindows,
ash::switches::kAshEnableImmersiveFullscreenForBrowserOnly)
},
+ {
+ "network-portal-notification",
+ IDS_FLAGS_NETWORK_PORTAL_NOTIFICATION_NAME,
+ IDS_FLAGS_NETWORK_PORTAL_NOTIFICATION_DESCRIPTION,
+ kOsCrOS,
+ MULTI_VALUE_TYPE(kNetworkPortalNotificationChoices)
+ },
#endif
{
"enable-download-resumption",

Powered by Google App Engine
This is Rietveld 408576698