Added in-session captive portal notification.

chromeos/chromeos_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/chromeos_switches.h"
 
 namespace chromeos {
 namespace switches {
 
 // Path for app's OEM manifest file.
@@ skipping 49 matching lines @@
 const char kDisableNewKioskUI[]             = "disable-new-kiosk-ui";
 
 // Disable Quickoffice component app thus handlers won't be registered so
 // it will be possible to install another version as normal app for testing.
 const char kDisableQuickofficeComponentApp[] =
     "disable-quickoffice-component-app";
 
 // Disables volume adjust sound.
 const char kDisableVolumeAdjustSound[] = "disable-volume-adjust-sound";
 
+// Disables notifications about captive portals in session.
+const char kDisableNetworkPortalNotification[] =
+    "disable-network-portal-notification";
+
 // Disables fetching online CrOS EULA page, only static version is shown.
 const char kDisableOnlineEULA[] = "disable-cros-online-eula";
 
 // Avoid doing animations upon oobe.
 const char kDisableOobeAnimation[]          = "disable-oobe-animation";
 
 // Disables portal detection and network error handling before auto
 // update.
 const char kDisableOOBEBlockingUpdate[] =
     "disable-oobe-blocking-update";
 
 // Enables overriding the path for the default echo component extension.
 // Useful for testing.
 const char kEchoExtensionPath[]             = "echo-ext-path";
 
 // Enables component extension that initializes background pages of
 // certain hosted applications.
 const char kEnableBackgroundLoader[]        = "enable-background-loader";
 
 // Enables switching between different cellular carriers from the UI.
 const char kEnableCarrierSwitching[]        = "enable-carrier-switching";
 
+// Enables notifications about captive portals in session.
+const char kEnableNetworkPortalNotification[] =
+    "enable-network-portal-notification";

[oshima, 2014/02/19 18:59:41]

why you need both enable/disable now?

[ygorshenin1, 2014/02/20 16:31:39]

For easy switch of default behavior. Currently by default this notification is
disabled. When this feature will be production-ready, it should be enabled by
default. To do this currently I just need to slightly change
IsPortalNotificationEnabled() function.

On 2014/02/19 18:59:41, oshima wrote:

+
 // Enable "interactive" mode for stub implemenations (e.g. NetworkStateHandler)
 const char kEnableStubInteractive[] = "enable-stub-interactive";
 
 // Enable stub portalled wifi network for testing.
 const char kEnableStubPortalledWifi[] = "enable-stub-portalled-wifi";
 
 // Enables touchpad three-finger-click as middle button.
 const char kEnableTouchpadThreeFingerClick[]
     = "enable-touchpad-three-finger-click";
 
@@ skipping 119 matching lines @@
 const char kForceFirstRunUI[] = "force-first-run-ui";
 
 // Enables testing for auto update UI.
 const char kTestAutoUpdateUI[] = "test-auto-update-ui";
 
 // Enables features required for supervised user sync,
 const char kEnableSupervisedPasswordSync[] = "enable-supervised-password-sync";
 
 }  // namespace switches
 }  // namespace chromeos