Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 171423005: Added in-session captive portal notification. (Closed)

Created:
6 years, 10 months ago by ygorshenin1
Modified:
6 years, 10 months ago
Reviewers:
Jun Mukai, oshima
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Added in-session captive portal notification. BUG=240237 TEST=unit_tests:NetworkPortalDetectorNotification* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252547

Patch Set 1 #

Patch Set 2 : Fix. #

Total comments: 22

Patch Set 3 : Fixes. #

Total comments: 13

Patch Set 4 : Fix. #

Patch Set 5 : Fix, rebase. #

Patch Set 6 : Fix. #

Patch Set 7 : Deleted useless NotificaionDisplayed(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -0 lines) Patch
M ash/system/system_notifier.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/system_notifier.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/net/network_portal_notification_controller.h View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/net/network_portal_notification_controller.cc View 1 2 3 4 5 6 1 chunk +136 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc View 1 2 1 chunk +199 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
ygorshenin1
6 years, 10 months ago (2014-02-19 09:00:52 UTC) #1
oshima
I'm not familiar with notification code. mukai-san, can you review thsi too? https://codereview.chromium.org/171423005/diff/30001/chrome/browser/chromeos/net/network_portal_detector_notification.cc File chrome/browser/chromeos/net/network_portal_detector_notification.cc ...
6 years, 10 months ago (2014-02-19 18:59:41 UTC) #2
Jun Mukai
https://codereview.chromium.org/171423005/diff/30001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/171423005/diff/30001/chrome/app/generated_resources.grd#newcode7024 chrome/app/generated_resources.grd:7024: + <if expr="pp_ifdef('chromeos')"> If this is chromeos-specific, consider adding ...
6 years, 10 months ago (2014-02-19 19:17:25 UTC) #3
ygorshenin1
PTAL https://codereview.chromium.org/171423005/diff/30001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/171423005/diff/30001/chrome/app/generated_resources.grd#newcode7024 chrome/app/generated_resources.grd:7024: + <if expr="pp_ifdef('chromeos')"> On 2014/02/19 19:17:25, Jun Mukai ...
6 years, 10 months ago (2014-02-20 16:31:39 UTC) #4
Jun Mukai
lgtm on notification side. https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.cc File chrome/browser/chromeos/net/network_portal_notification_controller.cc (right): https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.cc#newcode64 chrome/browser/chromeos/net/network_portal_notification_controller.cc:64: virtual ~NetworkPortalNotificationControllerDelegate() {} Did your ...
6 years, 10 months ago (2014-02-20 18:30:15 UTC) #5
oshima
lgtm with nits https://codereview.chromium.org/171423005/diff/20014/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/171423005/diff/20014/chrome/browser/about_flags.cc#newcode350 chrome/browser/about_flags.cc:350: nit: remove extra line https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.cc File ...
6 years, 10 months ago (2014-02-20 19:00:52 UTC) #6
Jun Mukai
https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.cc File chrome/browser/chromeos/net/network_portal_notification_controller.cc (right): https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.cc#newcode71 chrome/browser/chromeos/net/network_portal_notification_controller.cc:71: if (button_index != 0) On 2014/02/20 19:00:54, oshima wrote: ...
6 years, 10 months ago (2014-02-20 19:04:19 UTC) #7
ygorshenin1
Many thanks! https://codereview.chromium.org/171423005/diff/20014/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/171423005/diff/20014/chrome/browser/about_flags.cc#newcode350 chrome/browser/about_flags.cc:350: On 2014/02/20 19:00:54, oshima wrote: > nit: ...
6 years, 10 months ago (2014-02-20 19:18:45 UTC) #8
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 10 months ago (2014-02-20 19:24:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/171423005/440001
6 years, 10 months ago (2014-02-20 19:24:54 UTC) #10
oshima
still lgtm https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.h File chrome/browser/chromeos/net/network_portal_notification_controller.h (right): https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.h#newcode10 chrome/browser/chromeos/net/network_portal_notification_controller.h:10: #include "base/basictypes.h" On 2014/02/20 19:18:45, ygorshenin1 wrote: ...
6 years, 10 months ago (2014-02-20 20:26:49 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 21:09:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-20 21:09:50 UTC) #13
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 10 months ago (2014-02-21 09:04:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/171423005/630001
6 years, 10 months ago (2014-02-21 09:04:47 UTC) #15
ygorshenin1
https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.h File chrome/browser/chromeos/net/network_portal_notification_controller.h (right): https://codereview.chromium.org/171423005/diff/20014/chrome/browser/chromeos/net/network_portal_notification_controller.h#newcode10 chrome/browser/chromeos/net/network_portal_notification_controller.h:10: #include "base/basictypes.h" On 2014/02/20 20:26:50, oshima wrote: > On ...
6 years, 10 months ago (2014-02-21 09:04:55 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 10:34:56 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=73893
6 years, 10 months ago (2014-02-21 10:34:56 UTC) #18
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 10 months ago (2014-02-21 10:58:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/171423005/890001
6 years, 10 months ago (2014-02-21 10:59:12 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 14:27:38 UTC) #21
Message was sent while issue was closed.
Change committed as 252547

Powered by Google App Engine
This is Rietveld 408576698