Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 171423004: Fix uninit read in TestRunner. (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
Reviewers:
dcarney
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Fix uninit read in TestRunner. Only happens if the testrunner methods are invoked with invalid arguments. Protect against that. BUG=344762 R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/shell/renderer/test_runner/TestRunner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-19 08:17:45 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-19 08:18:15 UTC) #2
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-19 08:19:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r251994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698