Issue 171423003: Update local BaseScrollBar::contents_scroll_offset_ on Update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171423003: Update local BaseScrollBar::contents_scroll_offset_ on Update. (Closed)

Created:
6 years, 10 months ago by msw

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update local BaseScrollBar::contents_scroll_offset_ on Update. Make ScrollByContentsOffset() work as intended after resize. contents_scroll_offset_ was not being updated on Update(). Add a test that fails without this fix. Fix an Aura include. BUG=344490 TEST=Click page icon, click "Show cookies and site data". Expand a node to make a scrollbar appear, scroll down; collapse the node, re-expand the node; scrolling down should work. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252097

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
M	ui/views/controls/scrollbar/base_scroll_bar.cc	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/views/controls/scrollbar/native_scroll_bar.cc	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	ui/views/controls/scrollbar/scrollbar_unittest.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/171423003/120001

6 years, 10 months ago (2014-02-19 16:23:26 UTC) #4

Message was sent while issue was closed.

Change committed as 252097

Expand Messages | Collapse Messages

Issue 171423003: Update local BaseScrollBar::contents_scroll_offset_ on Update. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add and re-enable unittests; cleanup Aura include. #

Patch Set 3 : Keep disabled tests disabled. #

Messages