Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1714173002: Add summary support for ShowElementCombinator.end and .offset. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/idl.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index d6210db1fff40d94e18b4eb30dad80dc21ceaeae..3273c9fa2c6cf5fd395b68d3dd38a3298ff0d546 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -32,7 +32,10 @@ class _CombinatorEncoder extends SimpleAstVisitor<UnlinkedCombinatorBuilder> {
@override
UnlinkedCombinatorBuilder visitShowCombinator(ShowCombinator node) {
- return new UnlinkedCombinatorBuilder(shows: encodeNames(node.shownNames));
+ return new UnlinkedCombinatorBuilder(
+ shows: encodeNames(node.shownNames),
+ offset: node.offset,
+ end: node.end);
}
}
@@ -92,8 +95,7 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
member.typeParameters?.typeParameters?.length ?? 0));
}
}
- if (member is ConstructorDeclaration &&
- member.name != null) {
+ if (member is ConstructorDeclaration && member.name != null) {
String name = member.name.name;
if (isPublic(name)) {
cls.members.add(new UnlinkedPublicNameBuilder(
« no previous file with comments | « pkg/analyzer/lib/src/summary/idl.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698