Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171413002: linux_aura: Keep GTK state from leaking between profiles. (Closed)

Created:
6 years, 10 months ago by Elliot Glaysher
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

linux_aura: Keep GTK state from leaking between profiles. The views::LinuxUI* object is global across profiles. However, it stored profile specific state in the form of a |use_gtk_| variable. This fixes Gtk2Borders so that they ask their owning view for a ThemeProvider and expands the ui::ThemeProvider interface so that it exposes the UsingNativeTheme() call from the ThemeService layer, instead of asking the views::LinuxUI provider directly, which will likely return stale state. BUG=340805, 340799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252085

Patch Set 1 #

Patch Set 2 : Remove forward declarations. #

Patch Set 3 : Fix windows build. #

Patch Set 4 : add dependency in the unit tests too. #

Patch Set 5 : Revert the accidently applied patch from another CL. #

Patch Set 6 : Fix mac compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -46 lines) Patch
M chrome/browser/themes/theme_service.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/theme_service_aurax11.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/download/background_theme.mm View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_border.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_border.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/default_theme_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/default_theme_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/theme_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Elliot Glaysher
6 years, 10 months ago (2014-02-19 00:47:27 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-19 00:57:20 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 10 months ago (2014-02-19 02:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/171413002/190001
6 years, 10 months ago (2014-02-19 02:56:19 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 04:20:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=266173
6 years, 10 months ago (2014-02-19 04:20:10 UTC) #6
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 10 months ago (2014-02-19 18:44:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/171413002/380001
6 years, 10 months ago (2014-02-19 18:48:27 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 21:08:02 UTC) #9
Message was sent while issue was closed. 
Change committed as 252085

Powered by Google App Engine
This is Rietveld 408576698