Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1714123002: PPC: [stubs] Introduce a dedicated FastNewObjectStub. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Introduce a dedicated FastNewObjectStub. Port ba2077aac3a775523ca3fc9600fcf76f55e8d1c2 Original commit message: Move the already existing fast case for %NewObject into a dedicated FastNewObjectStub that we can utilize in places where we would otherwise fallback to %NewObject immediately, which is rather expensive. Also use FastNewObjectStub as the generic implementation of JSCreate, which should make constructor inlining based on SharedFunctionInfo (w/o specializing to a concrete closure) viable soon. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/a509b105d85821c87e2a8530369160be559e500b Cr-Commit-Position: refs/heads/master@{#34169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -137 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +15 lines, -137 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +122 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-19 18:33:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714123002/1
4 years, 10 months ago (2016-02-19 18:34:12 UTC) #3
JoranSiu
On 2016/02/19 18:34:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 10 months ago (2016-02-19 18:36:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 18:53:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714123002/1
4 years, 10 months ago (2016-02-19 18:56:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 18:58:03 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a509b105d85821c87e2a8530369160be559e500b Cr-Commit-Position: refs/heads/master@{#34169}
4 years, 10 months ago (2016-02-19 18:58:16 UTC) #11
ascy
4 years, 10 months ago (2016-02-21 08:58:13 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698