Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1714113002: Add summary support for ParameterElement.defaultValueCode. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add summary support for ParameterElement.defaultValueCode. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e78bc9386edacd4a662df8f8b297b924e96db374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 11 chunks +31 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 12 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-19 18:30:32 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-19 18:32:20 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-19 18:35:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e78bc9386edacd4a662df8f8b297b924e96db374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698