Issue 17141005: DevTools: CPUProfiler: provide url for scripts that have sourceURL property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17141005: DevTools: CPUProfiler: provide url for scripts that have sourceURL property. (Closed)

Created:
7 years, 6 months ago by loislo

Modified:
7 years, 5 months ago

Reviewers:
alph, yurys

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

DevTools: CPUProfiler: provide url for scripts that have sourceURL property. BUG=none TEST=SourceURLSupportForNewFunctions, LogExistingFunctionSourceURLCheck

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -3 lines)			Patch
M	src/api.cc	View	1 chunk	+7 lines, -0 lines	1 comment	Download
M	src/compiler.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/cpu-profiler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 6 months ago (2013-06-17 18:34:14 UTC) #2

https://codereview.chromium.org/17141005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/17141005/diff/1/src/api.cc#newcode7378
src/api.cc:7378: v8::Context::Scope contextScope(context);
not lgtm, we shouldn't create and enter contexts as profiled application may not
expect it. In Chrome e.g. bindings code would assume that entered js context has
a reference to the DOMWindow somewhere in its internal fields.

Expand Messages | Collapse Messages