Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 17141005: DevTools: CPUProfiler: provide url for scripts that have sourceURL property. (Closed)

Created:
7 years, 6 months ago by loislo
Modified:
7 years, 5 months ago
Reviewers:
alph, yurys
CC:
v8-dev
Visibility:
Public.

Description

DevTools: CPUProfiler: provide url for scripts that have sourceURL property. BUG=none TEST=SourceURLSupportForNewFunctions, LogExistingFunctionSourceURLCheck

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -3 lines) Patch
M src/api.cc View 1 chunk +7 lines, -0 lines 1 comment Download
M src/compiler.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/cpu-profiler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/handles.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
loislo
7 years, 6 months ago (2013-06-17 18:27:26 UTC) #1
yurys
7 years, 6 months ago (2013-06-17 18:34:14 UTC) #2
https://codereview.chromium.org/17141005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/17141005/diff/1/src/api.cc#newcode7378
src/api.cc:7378: v8::Context::Scope contextScope(context);
not lgtm, we shouldn't create and enter contexts as profiled application may not
expect it. In Chrome e.g. bindings code would assume that entered js context has
a reference to the DOMWindow somewhere in its internal fields.

Powered by Google App Engine
This is Rietveld 408576698