third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt - Issue 1714063002: Protect the provisional loader from detaching during prepareForCommit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt

Issue 1714063002: Protect the provisional loader from detaching during prepareForCommit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a layout test, fixed bugs with initial fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit.html ('k') | third_party/WebKit/Source/core/loader/FrameLoader.h » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt

diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/onload-vs-immediate-refresh-expected.txt b/third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt

similarity index 89%

copy from third_party/WebKit/LayoutTests/http/tests/loading/onload-vs-immediate-refresh-expected.txt

copy to third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt

index cf0d0019dd44580e3360901d934e8ed230729536..d8ce6ca6a67d40c343b6bf7a662850fddda34ff8 100644

--- a/third_party/WebKit/LayoutTests/http/tests/loading/onload-vs-immediate-refresh-expected.txt

+++ b/third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt

@@ -1,7 +1,6 @@

main frame - didStartProvisionalLoadForFrame

main frame - didCommitLoadForFrame

main frame - didFinishDocumentLoadForFrame

-ALERT: SUCCESS

main frame - didHandleOnloadEventsForFrame

main frame - didFinishLoadForFrame

main frame - didStartProvisionalLoadForFrame

@@ -9,4 +8,4 @@ main frame - didCommitLoadForFrame

main frame - didFinishDocumentLoadForFrame

main frame - didHandleOnloadEventsForFrame

main frame - didFinishLoadForFrame

-You should have seen an alert.

+PASS