third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit.html - Issue 1714063002: Protect the provisional loader from detaching during prepareForCommit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit.html

Issue 1714063002: Protect the provisional loader from detaching during prepareForCommit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a layout test, fixed bugs with initial fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner) {

	4 testRunner.dumpAsText();

	5 testRunner.waitUntilDone();

	6 }

	7

	8 function abortFunc() {

	9 window.stop();

	10 }

	11

	12 function onload() {

	13 var oReq = new XMLHttpRequest();

	14 oReq.addEventListener("abort", abortFunc);

	15 oReq.open("GET", "/resources/slow-script.pl");

	16 oReq.send();

	17 window.location = "/navigation/resources/pass-and-notify-done.html";

	18 }

	19 </script>

	20 <body onload="onload();">

	21 <div>Test should not end on this page</div>

	22 </body>

OLD	NEW