Add touch flag to output of Schema::Normalize()

Add touch flag to output of Schema::Normalize()

BUG=258339
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254107

[binjin, 2014-02-19 16:39:48]

Hello Joao,

PTAL at this CL, thanks

Bin

[Joao da Silva, 2014-02-20 12:46:40]

What is the |changed| value going to be used for?

https://codereview.chromium.org/171403004/diff/1/components/policy/core/commo...
File components/policy/core/common/schema_unittest.cc (right):

https://codereview.chromium.org/171403004/diff/1/components/policy/core/commo...
components/policy/core/common/schema_unittest.cc:131: returned =
schema.Normalize(cloned_value.get(), strategy, NULL, &error, NULL);
Add tests that verify the |changed| argument

[binjin, 2014-02-20 15:48:33]

On 2014/02/20 12:46:40, Joao da Silva wrote:
> What is the |changed| value going to be used for?
> 

Hello Joao,

This CL is needed, because I want to warn the user when the schema is not
strictly valid but calling the same function twice with different strategy looks
like a bad idea to me.

Bin

https://codereview.chromium.org/171403004/diff/1/components/policy/core/commo...
File components/policy/core/common/schema_unittest.cc (right):

https://codereview.chromium.org/171403004/diff/1/components/policy/core/commo...
components/policy/core/common/schema_unittest.cc:131: returned =
schema.Normalize(cloned_value.get(), strategy, NULL, &error, NULL);
On 2014/02/20 12:46:41, Joao da Silva wrote:
> Add tests that verify the |changed| argument

Done.

[Joao da Silva, 2014-02-24 10:55:11]

lgtm

[binjin, 2014-02-28 01:54:03]

The CQ bit was checked by binjin@chromium.org

[commit-bot: I haz the power, 2014-02-28 01:54:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binjin@chromium.org/171403004/130001

[commit-bot: I haz the power, 2014-02-28 02:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 02:52:53]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, gfx_unittests,
google_apis_unittests, gpu_unittests, installer_util_unittests, ipc_tests,
jingle_unittests, media_unittests, mini_installer_test, nacl_integration,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[binjin, 2014-02-28 10:21:29]

The CQ bit was checked by binjin@chromium.org

[commit-bot: I haz the power, 2014-02-28 10:21:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binjin@chromium.org/171403004/130001

[commit-bot: I haz the power, 2014-02-28 14:41:55]

Change committed as 254107