Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1714023002: Revert of Only call gles2::Terminate when all Display objects are deleted (Closed)

Created:
4 years, 10 months ago by markusheintz_
Modified:
4 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@egl_test_branch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only call gles2::Terminate when all Display objects are deleted (patchset #3 id:40001 of ) Reason for revert: Does not compile on win c:\b\build\slave\win\build\src\gpu\command_buffer\tests\egl_test.cc(87) : error C2059: syntax error : '(' c:\b\build\slave\win\build\src\gpu\command_buffer\tests\egl_test.cc(90) : error C2061: syntax error : identifier 'glEnableProc' c:\b\build\slave\win\build\src\gpu\command_buffer\tests\egl_test.cc(91) : error C3536: 'GLES2Enable': cannot be used before it is initialized c:\b\build\slave\win\build\src\gpu\command_buffer\tests\egl_test.cc(91) : error C2064: term does not evaluate to a function taking 1 arguments https://build.chromium.org/p/chromium/builders/Win/builds/40478/steps/compile/logs/stdio Original issue's description: > Only call gles2::Terminate when all Display objects are deleted > > Implementation in command buffer EGL calls gles2::Terminate and gles2::Initialize incorrectly. If there are multiple Display objects each will call Initialize and Terminate and creates and frees the TLS allocated context key twice. It should only be created once and freed once all the Displays are deleted. > > BUG=skia:2992 > > Committed: https://crrev.com/c22b484a0aaabbfbce221b419da48bca080e7826 > Cr-Commit-Position: refs/heads/master@{#376439} TBR=piman@chromium.org,kkinnunen@nvidia.com,svaisanen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://crrev.com/be8017a38ab65cf3e2e9692767c23f15144be686 Cr-Commit-Position: refs/heads/master@{#376443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -152 lines) Patch
M gpu/command_buffer/tests/egl_test.cc View 2 chunks +1 line, -106 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +29 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
markusheintz_
Created Revert of Only call gles2::Terminate when all Display objects are deleted
4 years, 10 months ago (2016-02-19 15:39:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714023002/1
4 years, 10 months ago (2016-02-19 15:45:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 15:49:42 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 15:52:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be8017a38ab65cf3e2e9692767c23f15144be686
Cr-Commit-Position: refs/heads/master@{#376443}

Powered by Google App Engine
This is Rietveld 408576698