test/test262/archive.py - Issue 1713993002: [Swarming] Speed up test262 upload/download.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/test262/archive.py

Issue 1713993002: [Swarming] Speed up test262 upload/download. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 # Copyright 2016 the V8 project authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 import os

	7 import tarfile

	8

	9 os.chdir(os.path.dirname(os.path.abspath(__file__)))

	10

	11 def filter_git(tar_info):

	12 return None if tar_info.name.startswith('data/.git') else tar_info
	Michael Achenbach 2016/02/19 14:02:49 hmm - wondering if this is a \ on windows and it t hmm - wondering if this is a \ on windows and it tars the .git folder... would explain why it's so slow... tandrii(chromium) 2016/02/19 14:12:50 well you can definitely test for both here. Show quoted text On 2016/02/19 14:02:49, Michael Achenbach wrote: > hmm - wondering if this is a \ on windows and it tars the .git folder... would > explain why it's so slow... well you can definitely test for both here. Michael Achenbach 2016/02/19 14:26:58 Using os.path.join here now. It indeed caused the Show quoted text On 2016/02/19 14:12:50, tandrii(chromium) wrote: > On 2016/02/19 14:02:49, Michael Achenbach wrote: > > hmm - wondering if this is a \ on windows and it tars the .git folder... would > > explain why it's so slow... > > well you can definitely test for both here. Using os.path.join here now. It indeed caused the windows slowness. Now windows takes only 30s instead of 70s. I'll update the CL description.
	13

	14 with tarfile.open('data.tar', 'w') as tar:

	15 tar.add('data', filter=filter_git)

OLD	NEW

« no previous file with comments | « .gitignore ('k') | test/test262/list.py » ('j') | no next file with comments »