Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1713983002: dart2js cps: Add SetLength instruction. (Closed)

Created:
4 years, 10 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Use trust-primitives and refine type of length to uint32' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
M pkg/compiler/lib/src/cps_ir/bounds_checker.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/builtin_operator.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 1 chunk +32 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1713983002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1713983002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode1534 pkg/compiler/lib/src/cps_ir/type_propagation.dart:1534: if (!typeSystem.isDefinitelyUint32(newLength.type)) { consider also having an option ...
4 years, 10 months ago (2016-02-23 17:39:51 UTC) #2
asgerf
https://codereview.chromium.org/1713983002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1713983002/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode1534 pkg/compiler/lib/src/cps_ir/type_propagation.dart:1534: if (!typeSystem.isDefinitelyUint32(newLength.type)) { On 2016/02/23 17:39:51, Siggi Cherem (dart-lang) ...
4 years, 9 months ago (2016-02-29 11:31:43 UTC) #3
asgerf
4 years, 9 months ago (2016-02-29 11:42:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a3804f6fc8a9726ced99bfdf79691009d2415b45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698