third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl - Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix expected Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('K') | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

index 2908a9c71f3517723e67e78e899c141579e7ea3f..a956d659932a09d287c203dea4beed6b1131c813 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

@@ -99,9 +99,9 @@ enum RTCIceConnectionState {

// https://w3c.github.io/webrtc-pc/#legacy-interface-extensions

// These methods return or will be changed to return Promise<void> because

// having Promise-based versions requires that all overloads return Promises.

- [CallWith=ExecutionContext, RaisesException] void createOffer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);

+ [CallWith=ExecutionContext] void createOffer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary rtcOfferOptions);

// TODO(guidou): There should be no mediaConstraints argument.

- [CallWith=ExecutionContext, RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);

+ [CallWith=ExecutionContext] void createAnswer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);

[CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);

// TODO(guidou): The failureCallback argument should be non-optional.

[CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);