third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h - Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix expected Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

index 06a9e7878d3ebece1ec0bdffc7bed1e933934cae..4080d6b3fb86b845fee88eaead15ced70f066a13 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

@@ -71,9 +71,9 @@ public:

static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&);

~RTCPeerConnection() override;

- void createOffer(ExecutionContext*, RTCSessionDescriptionCallback*, RTCErrorCallback*, const Dictionary&, ExceptionState&);

+ void createOffer(ExecutionContext*, RTCSessionDescriptionCallback*, RTCErrorCallback*, const Dictionary&);

- void createAnswer(ExecutionContext*, RTCSessionDescriptionCallback*, RTCErrorCallback*, const Dictionary&, ExceptionState&);

+ void createAnswer(ExecutionContext*, RTCSessionDescriptionCallback*, RTCErrorCallback*, const Dictionary&);

ScriptPromise setLocalDescription(ScriptState*, const RTCSessionDescriptionInit&);

ScriptPromise setLocalDescription(ScriptState*, RTCSessionDescription*, VoidCallback*, RTCErrorCallback*);

@@ -178,7 +178,7 @@ private:

RTCPeerConnection(ExecutionContext*, RTCConfiguration*, WebMediaConstraints, ExceptionState&);

static RTCConfiguration* parseConfiguration(const Dictionary&, ExceptionState&);

- static RTCOfferOptions* parseOfferOptions(const Dictionary&, ExceptionState&);

+ static RTCOfferOptions* parseOfferOptions(const Dictionary&, RTCErrorCallback*, bool& hadError);

void scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event>);

void scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event>, PassOwnPtr<BoolFunction>);