Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ignore ConstraintErrors produced by the constraints parser Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 [RaisesException] void close(); 91 [RaisesException] void close();
92 attribute EventHandler onnegotiationneeded; 92 attribute EventHandler onnegotiationneeded;
93 attribute EventHandler onicecandidate; 93 attribute EventHandler onicecandidate;
94 attribute EventHandler onsignalingstatechange; 94 attribute EventHandler onsignalingstatechange;
95 attribute EventHandler oniceconnectionstatechange; 95 attribute EventHandler oniceconnectionstatechange;
96 // attribute EventHandler onicegatheringstatechange; 96 // attribute EventHandler onicegatheringstatechange;
97 97
98 // https://w3c.github.io/webrtc-pc/#legacy-interface-extensions 98 // https://w3c.github.io/webrtc-pc/#legacy-interface-extensions
99 // These methods return or will be changed to return Promise<void> because 99 // These methods return or will be changed to return Promise<void> because
100 // having Promise-based versions requires that all overloads return Promises . 100 // having Promise-based versions requires that all overloads return Promises .
101 [CallWith=ExecutionContext, RaisesException] void createOffer(RTCSessionDesc riptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dictionary rtcOfferOptions); 101 [CallWith=ExecutionContext] void createOffer(RTCSessionDescriptionCallback s uccessCallback, RTCPeerConnectionErrorCallback failureCallback, optional Diction ary rtcOfferOptions);
102 // TODO(guidou): There should be no mediaConstraints argument. 102 // TODO(guidou): There should be no mediaConstraints argument.
103 [CallWith=ExecutionContext, RaisesException] void createAnswer(RTCSessionDes criptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback , optional Dictionary mediaConstraints); 103 [CallWith=ExecutionContext] void createAnswer(RTCSessionDescriptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dictio nary mediaConstraints);
104 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti on description, VoidCallback successCallback, [Default=Undefined] optional RTCPe erConnectionErrorCallback failureCallback); 104 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti on description, VoidCallback successCallback, [Default=Undefined] optional RTCPe erConnectionErrorCallback failureCallback);
105 // TODO(guidou): The failureCallback argument should be non-optional. 105 // TODO(guidou): The failureCallback argument should be non-optional.
106 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ion description, VoidCallback successCallback, [Default=Undefined] optional RTCP eerConnectionErrorCallback failureCallback); 106 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ion description, VoidCallback successCallback, [Default=Undefined] optional RTCP eerConnectionErrorCallback failureCallback);
107 [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candida te, VoidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback ); 107 [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candida te, VoidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback );
108 // TODO(guidou): The selector argument should the first (nullable, 108 // TODO(guidou): The selector argument should the first (nullable,
109 // non-optional) argument, and there should be a third failureCallback 109 // non-optional) argument, and there should be a third failureCallback
110 // argument. 110 // argument.
111 [CallWith=ExecutionContext, LegacyInterfaceTypeChecking] void getStats(RTCSt atsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selec tor); 111 [CallWith=ExecutionContext, LegacyInterfaceTypeChecking] void getStats(RTCSt atsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selec tor);
112 112
113 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api 113 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
(...skipping 10 matching lines...) Expand all
124 [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? str eam, optional Dictionary mediaConstraints); 124 [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? str eam, optional Dictionary mediaConstraints);
125 [RaisesException] void removeStream(MediaStream? stream); 125 [RaisesException] void removeStream(MediaStream? stream);
126 [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track); 126 [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
127 attribute EventHandler onaddstream; 127 attribute EventHandler onaddstream;
128 attribute EventHandler onremovestream; 128 attribute EventHandler onremovestream;
129 129
130 // Certificate management 130 // Certificate management
131 // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt 131 // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt
132 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm); 132 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm);
133 }; 133 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698