Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix expected Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 [RaisesException] void close(); 92 [RaisesException] void close();
93 attribute EventHandler onnegotiationneeded; 93 attribute EventHandler onnegotiationneeded;
94 attribute EventHandler onicecandidate; 94 attribute EventHandler onicecandidate;
95 attribute EventHandler onsignalingstatechange; 95 attribute EventHandler onsignalingstatechange;
96 attribute EventHandler oniceconnectionstatechange; 96 attribute EventHandler oniceconnectionstatechange;
97 // attribute EventHandler onicegatheringstatechange; 97 // attribute EventHandler onicegatheringstatechange;
98 98
99 // https://w3c.github.io/webrtc-pc/#legacy-interface-extensions 99 // https://w3c.github.io/webrtc-pc/#legacy-interface-extensions
100 // These methods return or will be changed to return Promise<void> because 100 // These methods return or will be changed to return Promise<void> because
101 // having Promise-based versions requires that all overloads return Promises . 101 // having Promise-based versions requires that all overloads return Promises .
102 [CallWith=ExecutionContext, RaisesException] void createOffer(RTCSessionDesc riptionCallback successCallback, RTCErrorCallback failureCallback, optional Dict ionary rtcOfferOptions); 102 [CallWith=ExecutionContext] void createOffer(RTCSessionDescriptionCallback s uccessCallback, RTCErrorCallback failureCallback, optional Dictionary rtcOfferOp tions);
103 // TODO(guidou): There should be no mediaConstraints argument. 103 // TODO(guidou): There should be no mediaConstraints argument.
104 [CallWith=ExecutionContext, RaisesException] void createAnswer(RTCSessionDes criptionCallback successCallback, RTCErrorCallback failureCallback, optional Dic tionary mediaConstraints); 104 [CallWith=ExecutionContext] void createAnswer(RTCSessionDescriptionCallback successCallback, RTCErrorCallback failureCallback, optional Dictionary mediaCons traints);
105 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti on description, VoidCallback successCallback, [Default=Undefined] optional RTCEr rorCallback failureCallback); 105 [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescripti on description, VoidCallback successCallback, [Default=Undefined] optional RTCEr rorCallback failureCallback);
106 // TODO(guidou): The failureCallback argument should be non-optional. 106 // TODO(guidou): The failureCallback argument should be non-optional.
107 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ion description, VoidCallback successCallback, [Default=Undefined] optional RTCE rrorCallback failureCallback); 107 [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescript ion description, VoidCallback successCallback, [Default=Undefined] optional RTCE rrorCallback failureCallback);
108 [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candida te, VoidCallback successCallback, RTCErrorCallback failureCallback); 108 [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candida te, VoidCallback successCallback, RTCErrorCallback failureCallback);
109 // TODO(guidou): The selector argument should the first (nullable, 109 // TODO(guidou): The selector argument should the first (nullable,
110 // non-optional) argument, and there should be a third failureCallback 110 // non-optional) argument, and there should be a third failureCallback
111 // argument. 111 // argument.
112 [CallWith=ExecutionContext, LegacyInterfaceTypeChecking] void getStats(RTCSt atsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selec tor); 112 [CallWith=ExecutionContext, LegacyInterfaceTypeChecking] void getStats(RTCSt atsCallback successCallback, [Default=Undefined] optional MediaStreamTrack selec tor);
113 113
114 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api 114 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
(...skipping 10 matching lines...) Expand all
125 [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? str eam, optional Dictionary mediaConstraints); 125 [CallWith=ExecutionContext, RaisesException] void addStream(MediaStream? str eam, optional Dictionary mediaConstraints);
126 [RaisesException] void removeStream(MediaStream? stream); 126 [RaisesException] void removeStream(MediaStream? stream);
127 [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track); 127 [RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack track);
128 attribute EventHandler onaddstream; 128 attribute EventHandler onaddstream;
129 attribute EventHandler onremovestream; 129 attribute EventHandler onremovestream;
130 130
131 // Certificate management 131 // Certificate management
132 // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt 132 // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt
133 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm); 133 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm);
134 }; 134 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698