Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 334
335 case UseCounter::BluetoothDeviceConnectGATT: 335 case UseCounter::BluetoothDeviceConnectGATT:
336 return replacedWillBeRemoved("'BluetoothDevice.connectGATT'", "'Bluetoot hDevice.gatt.connect'", 52, "5264933985976320"); 336 return replacedWillBeRemoved("'BluetoothDevice.connectGATT'", "'Bluetoot hDevice.gatt.connect'", 52, "5264933985976320");
337 337
338 case UseCounter::MediaStreamTrackGetSources: 338 case UseCounter::MediaStreamTrackGetSources:
339 return "MediaStreamTrack.getSources is deprecated. See https://www.chrom estatus.com/feature/4765305641369600 for more details."; 339 return "MediaStreamTrack.getSources is deprecated. See https://www.chrom estatus.com/feature/4765305641369600 for more details.";
340 340
341 case UseCounter::V8TouchEvent_InitTouchEvent_Method: 341 case UseCounter::V8TouchEvent_InitTouchEvent_Method:
342 return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEv ent constructor", 53, "5730982598541312"); 342 return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEv ent constructor", 53, "5730982598541312");
343 343
344 case UseCounter::RTCPeerConnectionCreateAnswerLegacyNoFailureCallback:
345 return "RTCPeerConnection.CreateAnswer without a failure callback is dep recated. The failure callback will be a required parameter in M50. See https://w ww.chromestatus.com/feature/5663288008376320 for more details";
346
347 case UseCounter::RTCPeerConnectionCreateOfferLegacyNoFailureCallback:
348 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details";
349
350 case UseCounter::ObjectObserve: 344 case UseCounter::ObjectObserve:
351 return willBeRemoved("'Object.observe'", 50, "6147094632988672"); 345 return willBeRemoved("'Object.observe'", 50, "6147094632988672");
352 346
353 case UseCounter::SVGZoomEvent: 347 case UseCounter::SVGZoomEvent:
354 return willBeRemoved("'SVGZoomEvent'", 52, "5760883808534528"); 348 return willBeRemoved("'SVGZoomEvent'", 52, "5760883808534528");
355 349
356 case UseCounter::BorderImageWithBorderStyleNone: 350 case UseCounter::BorderImageWithBorderStyleNone:
357 return "Elements using the 'border-image' CSS property with no 'border-s tyle' set should have no border, but currently do. Setting 'border-style' will b e required in M51, around May 2016. See https://www.chromestatus.com/features/55 42503914668032 for more details."; 351 return "Elements using the 'border-image' CSS property with no 'border-s tyle' set should have no border, but currently do. Setting 'border-style' will b e required in M51, around May 2016. See https://www.chromestatus.com/features/55 42503914668032 for more details.";
358 352
359 case UseCounter::WebAnimationHyphenatedProperty: 353 case UseCounter::WebAnimationHyphenatedProperty:
360 return replacedWillBeRemoved("Hyphenated naming in Web Animations keyfra mes", "camelCase", 51, "5650817352728576"); 354 return replacedWillBeRemoved("Hyphenated naming in Web Animations keyfra mes", "camelCase", 51, "5650817352728576");
361 355
362 case UseCounter::PresentationConnectionStateChangeEventListener: 356 case UseCounter::PresentationConnectionStateChangeEventListener:
363 return replacedWillBeRemoved("'PresentationConnection.onstateachange'", "'PresentationConnection.on{connect,close,terminate}'", 51, "5662456714100736"); 357 return replacedWillBeRemoved("'PresentationConnection.onstateachange'", "'PresentationConnection.on{connect,close,terminate}'", 51, "5662456714100736");
364 358
365 case UseCounter::HTMLKeygenElement: 359 case UseCounter::HTMLKeygenElement:
366 return willBeRemoved("The <keygen> element", 54, "5716060992962560"); 360 return willBeRemoved("The <keygen> element", 54, "5716060992962560");
367 361
368 case UseCounter::ResultsAttribute: 362 case UseCounter::ResultsAttribute:
369 return willBeRemoved("'results' attribute", 53, "5738199536107520"); 363 return willBeRemoved("'results' attribute", 53, "5738199536107520");
370 364
371 // Features that aren't deprecated don't have a deprecation message. 365 // Features that aren't deprecated don't have a deprecation message.
372 default: 366 default:
373 return String(); 367 return String();
374 } 368 }
375 } 369 }
376 370
377 } // namespace blink 371 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698