Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused counters Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 323
324 case UseCounter::BluetoothDeviceConnectGATT: 324 case UseCounter::BluetoothDeviceConnectGATT:
325 return replacedWillBeRemoved("'BluetoothDevice.connectGATT'", "'Bluetoot hDevice.gatt.connect'", 52, "5264933985976320"); 325 return replacedWillBeRemoved("'BluetoothDevice.connectGATT'", "'Bluetoot hDevice.gatt.connect'", 52, "5264933985976320");
326 326
327 case UseCounter::MediaStreamTrackGetSources: 327 case UseCounter::MediaStreamTrackGetSources:
328 return "MediaStreamTrack.getSources is deprecated. See https://www.chrom estatus.com/feature/4765305641369600 for more details."; 328 return "MediaStreamTrack.getSources is deprecated. See https://www.chrom estatus.com/feature/4765305641369600 for more details.";
329 329
330 case UseCounter::V8TouchEvent_InitTouchEvent_Method: 330 case UseCounter::V8TouchEvent_InitTouchEvent_Method:
331 return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEv ent constructor", 53, "5730982598541312"); 331 return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEv ent constructor", 53, "5730982598541312");
332 332
333 case UseCounter::RTCPeerConnectionCreateAnswerLegacyNoFailureCallback:
334 return "RTCPeerConnection.CreateAnswer without a failure callback is dep recated. The failure callback will be a required parameter in M50. See https://w ww.chromestatus.com/feature/5663288008376320 for more details";
335
336 case UseCounter::RTCPeerConnectionCreateOfferLegacyNoFailureCallback:
337 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details";
338
339 case UseCounter::ObjectObserve: 333 case UseCounter::ObjectObserve:
340 return willBeRemoved("'Object.observe'", 50, "6147094632988672"); 334 return willBeRemoved("'Object.observe'", 50, "6147094632988672");
341 335
342 case UseCounter::SVGZoomEvent: 336 case UseCounter::SVGZoomEvent:
343 return willBeRemoved("'SVGZoomEvent'", 52, "5760883808534528"); 337 return willBeRemoved("'SVGZoomEvent'", 52, "5760883808534528");
344 338
345 case UseCounter::BorderImageWithBorderStyleNone: 339 case UseCounter::BorderImageWithBorderStyleNone:
346 return "Elements using the 'border-image' CSS property with no 'border-s tyle' set should have no border, but currently do. Setting 'border-style' will b e required in M51, around May 2016. See https://www.chromestatus.com/features/55 42503914668032 for more details."; 340 return "Elements using the 'border-image' CSS property with no 'border-s tyle' set should have no border, but currently do. Setting 'border-style' will b e required in M51, around May 2016. See https://www.chromestatus.com/features/55 42503914668032 for more details.";
347 341
348 case UseCounter::WebAnimationHyphenatedProperty: 342 case UseCounter::WebAnimationHyphenatedProperty:
349 return replacedWillBeRemoved("Hyphenated naming in Web Animations keyfra mes", "camelCase", 51, "5650817352728576"); 343 return replacedWillBeRemoved("Hyphenated naming in Web Animations keyfra mes", "camelCase", 51, "5650817352728576");
350 344
351 case UseCounter::PresentationConnectionStateChangeEventListener: 345 case UseCounter::PresentationConnectionStateChangeEventListener:
352 return replacedWillBeRemoved("'PresentationConnection.onstateachange'", "'PresentationConnection.on{connect,close,terminate}'", 51, "5662456714100736"); 346 return replacedWillBeRemoved("'PresentationConnection.onstateachange'", "'PresentationConnection.on{connect,close,terminate}'", 51, "5662456714100736");
353 347
354 case UseCounter::HTMLKeygenElement: 348 case UseCounter::HTMLKeygenElement:
355 return willBeRemoved("The <keygen> element", 54, "5716060992962560"); 349 return willBeRemoved("The <keygen> element", 54, "5716060992962560");
356 350
357 case UseCounter::ResultsAttribute: 351 case UseCounter::ResultsAttribute:
358 return willBeRemoved("'results' attribute", 53, "5738199536107520"); 352 return willBeRemoved("'results' attribute", 53, "5738199536107520");
359 353
360 // Features that aren't deprecated don't have a deprecation message. 354 // Features that aren't deprecated don't have a deprecation message.
361 default: 355 default:
362 return String(); 356 return String();
363 } 357 }
364 } 358 }
365 359
366 } // namespace blink 360 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698