Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: runtime/vm/assembler.cc

Issue 1713853003: VM: Share object pool entries for optimized static calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler.h ('k') | runtime/vm/assembler_arm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler.cc
diff --git a/runtime/vm/assembler.cc b/runtime/vm/assembler.cc
index 495419d747a7fe2e6e672c65aa015726d739ae96..318881cba119edc4248368283000f255d8ba0475 100644
--- a/runtime/vm/assembler.cc
+++ b/runtime/vm/assembler.cc
@@ -244,16 +244,16 @@ const Code::Comments& Assembler::GetCodeComments() const {
intptr_t ObjectPoolWrapper::AddObject(const Object& obj,
Patchability patchable) {
- return AddObject(ObjectPool::Entry(&obj), patchable);
+ return AddObject(ObjectPoolWrapperEntry(&obj), patchable);
}
intptr_t ObjectPoolWrapper::AddImmediate(uword imm) {
- return AddObject(ObjectPool::Entry(imm, ObjectPool::kImmediate),
+ return AddObject(ObjectPoolWrapperEntry(imm, ObjectPool::kImmediate),
kNotPatchable);
}
-intptr_t ObjectPoolWrapper::AddObject(ObjectPool::Entry entry,
+intptr_t ObjectPoolWrapper::AddObject(ObjectPoolWrapperEntry entry,
Patchability patchable) {
object_pool_.Add(entry);
if (patchable == kNotPatchable) {
@@ -265,7 +265,7 @@ intptr_t ObjectPoolWrapper::AddObject(ObjectPool::Entry entry,
}
-intptr_t ObjectPoolWrapper::FindObject(ObjectPool::Entry entry,
+intptr_t ObjectPoolWrapper::FindObject(ObjectPoolWrapperEntry entry,
Patchability patchable) {
// If the object is not patchable, check if we've already got it in the
// object pool.
@@ -282,20 +282,27 @@ intptr_t ObjectPoolWrapper::FindObject(ObjectPool::Entry entry,
intptr_t ObjectPoolWrapper::FindObject(const Object& obj,
Patchability patchable) {
- return FindObject(ObjectPool::Entry(&obj), patchable);
+ return FindObject(ObjectPoolWrapperEntry(&obj), patchable);
+}
+
+
+intptr_t ObjectPoolWrapper::FindObject(const Object& obj,
+ const Object& equivalence) {
+ return FindObject(ObjectPoolWrapperEntry(&obj, &equivalence),
+ kNotPatchable);
}
intptr_t ObjectPoolWrapper::FindImmediate(uword imm) {
- return FindObject(ObjectPool::Entry(imm, ObjectPool::kImmediate),
+ return FindObject(ObjectPoolWrapperEntry(imm, ObjectPool::kImmediate),
kNotPatchable);
}
intptr_t ObjectPoolWrapper::FindNativeEntry(const ExternalLabel* label,
Patchability patchable) {
- return FindObject(ObjectPool::Entry(label->address(),
- ObjectPool::kNativeEntry),
+ return FindObject(ObjectPoolWrapperEntry(label->address(),
+ ObjectPool::kNativeEntry),
patchable);
}
« no previous file with comments | « runtime/vm/assembler.h ('k') | runtime/vm/assembler_arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698