Source/core/css/MediaFeatureNames.h - Issue 171383002: A thread-safe Media Query Parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaFeatureNames.h

Issue 171383002: A thread-safe Media Query Parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Refactored and passes tests Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaFeatureNames.h

diff --git a/Source/core/css/MediaFeatureNames.h b/Source/core/css/MediaFeatureNames.h

index 762437242b8840eae47bc24c9f9af38dcb7f913f..46bab7d2974684b404e0e648f501a691c66301dd 100644

--- a/Source/core/css/MediaFeatureNames.h

+++ b/Source/core/css/MediaFeatureNames.h

@@ -21,7 +21,7 @@

#ifndef MediaFeatureNames_h

#define MediaFeatureNames_h

-#include "wtf/text/AtomicString.h"

+#include "wtf/text/WTFString.h"

namespace WebCore {

namespace MediaFeatureNames {

@@ -73,7 +73,7 @@ namespace MediaFeatureNames {

// end of macro

#ifndef CSS_MEDIAQUERY_NAMES_HIDE_GLOBALS

-#define CSS_MEDIAQUERY_NAMES_DECLARE(name, str) extern const AtomicString name##MediaFeature;

+#define CSS_MEDIAQUERY_NAMES_DECLARE(name, str) extern const String name##MediaFeature;

CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(CSS_MEDIAQUERY_NAMES_DECLARE)

#undef CSS_MEDIAQUERY_NAMES_DECLARE

#endif