Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: Source/core/css/MediaQueryExp.h

Issue 171383002: A thread-safe Media Query Parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/MediaQueryExp.h
diff --git a/Source/core/css/MediaQueryExp.h b/Source/core/css/MediaQueryExp.h
index 0586b0a6bb3cba271d9768ef865f9767dbdc81bf..06a91681cd17f615cce5bc11f7f8c8b060856008 100644
--- a/Source/core/css/MediaQueryExp.h
+++ b/Source/core/css/MediaQueryExp.h
@@ -33,7 +33,6 @@
#include "core/css/MediaFeatureNames.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/RefPtr.h"
-#include "wtf/text/AtomicString.h"
namespace WebCore {
class CSSParserValueList;
@@ -41,16 +40,16 @@ class CSSParserValueList;
class MediaQueryExp {
WTF_MAKE_FAST_ALLOCATED;
public:
- static PassOwnPtr<MediaQueryExp> create(const AtomicString& mediaFeature, CSSParserValueList*);
+ static PassOwnPtr<MediaQueryExp> create(const String& mediaFeature, CSSParserValueList*);
~MediaQueryExp();
- AtomicString mediaFeature() const { return m_mediaFeature; }
+ String mediaFeature() const { return m_mediaFeature; }
CSSValue* value() const { return m_value.get(); }
bool operator==(const MediaQueryExp& other) const
{
- return (other.m_mediaFeature == m_mediaFeature)
+ return (other.m_mediaFeatureHash == m_mediaFeatureHash)
&& ((!other.m_value && !m_value)
|| (other.m_value && m_value && other.m_value->equals(*m_value)));
}
@@ -62,9 +61,10 @@ public:
PassOwnPtr<MediaQueryExp> copy() const { return adoptPtr(new MediaQueryExp(*this)); }
private:
- MediaQueryExp(const AtomicString& mediaFeature, PassRefPtr<CSSValue>);
+ MediaQueryExp(StringImpl*, PassRefPtr<CSSValue>);
- AtomicString m_mediaFeature;
+ String m_mediaFeature;
+ unsigned m_mediaFeatureHash;
RefPtr<CSSValue> m_value;
};

Powered by Google App Engine
This is Rietveld 408576698