Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 1713753002: Allow linked types to refer to local executables. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow linked types to refer to local executables. This allows us to summarize propagated and inferred types for a number of corner cases where the type is a function type implied by a closure. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e8848d970a68f7c3a6d6f38978a370f6974a05bf

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -22 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 7 chunks +30 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +123 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +31 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +39 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 13 chunks +151 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-18 21:41:50 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1713753002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1713753002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode690 pkg/analyzer/lib/src/summary/resynthesize.dart:690: final VariableElement _enclosingElement; We could do @override final ...
4 years, 10 months ago (2016-02-18 21:53:51 UTC) #3
Paul Berry
https://codereview.chromium.org/1713753002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1713753002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode690 pkg/analyzer/lib/src/summary/resynthesize.dart:690: final VariableElement _enclosingElement; On 2016/02/18 21:53:51, scheglov wrote: > ...
4 years, 10 months ago (2016-02-18 22:14:23 UTC) #4
Paul Berry
4 years, 10 months ago (2016-02-18 22:18:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8848d970a68f7c3a6d6f38978a370f6974a05bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698