content/renderer/accessibility/blink_ax_tree_source.cc - Issue 1713723002: Implement accessibility support for CSS-transformed iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 1713723002: Implement accessibility support for CSS-transformed iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return gfx::Rect from AccessibilityTransformToRootCoordSpace, get rid of ifdefed-out code accidenta… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/accessibility_tree_formatter_blink.cc ('K') | « content/public/common/BUILD.gn ('k') | content/test/data/accessibility/html/frame/box.html » ('j') | content/test/data/accessibility/html/frame/nested-frame.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index b4094e0ded3c604bcc591f5515576fec3c302cec..7e742c52466f374d73778517bf091c913103783d 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -525,8 +525,11 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

src.minValueForRange());

}

- if (dst->role == ui::AX_ROLE_WEB_AREA)

+ if (dst->role == ui::AX_ROLE_WEB_AREA) {

dst->AddStringAttribute(ui::AX_ATTR_HTML_TAG, "#document");

+ dst->transform.reset(

+ new gfx::Transform(src.transformFromLocalParentFrame()));

+ }

if (dst->role == ui::AX_ROLE_TABLE) {

int column_count = src.columnCount();