Implement accessibility support for CSS-transformed iframes.

content/browser/accessibility/browser_accessibility_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_H_
 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_H_
 
 #include <stdint.h>
 
 #include <vector>
@@ skipping 17 matching lines @@
 class BrowserAccessibility;
 class BrowserAccessibilityManager;
 #if defined(OS_ANDROID)
 class BrowserAccessibilityManagerAndroid;
 #elif defined(OS_WIN)
 class BrowserAccessibilityManagerWin;
 #elif defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_X11)
 class BrowserAccessibilityManagerAuraLinux;
 #endif
 
+class SiteInstance;
+
 // For testing.
 CONTENT_EXPORT ui::AXTreeUpdate MakeAXTreeUpdate(
     const ui::AXNodeData& node,
     const ui::AXNodeData& node2 = ui::AXNodeData(),
     const ui::AXNodeData& node3 = ui::AXNodeData(),
     const ui::AXNodeData& node4 = ui::AXNodeData(),
     const ui::AXNodeData& node5 = ui::AXNodeData(),
     const ui::AXNodeData& node6 = ui::AXNodeData(),
     const ui::AXNodeData& node7 = ui::AXNodeData(),
     const ui::AXNodeData& node8 = ui::AXNodeData(),
@@ skipping 24 matching lines @@
   virtual void AccessibilitySetSelection(int anchor_obj_id,
                                          int anchor_offset,
                                          int focus_obj_id,
                                          int focus_offset) = 0;
   virtual void AccessibilitySetValue(
       int acc_obj_id, const base::string16& value) = 0;
   virtual bool AccessibilityViewHasFocus() const = 0;
   virtual gfx::Rect AccessibilityGetViewBounds() const = 0;
   virtual gfx::Point AccessibilityOriginInScreen(
       const gfx::Rect& bounds) const = 0;
+  virtual gfx::Rect AccessibilityTransformToRootCoordSpace(
+      const gfx::Rect& bounds) = 0;

[dcheng, 2016/03/23 05:26:00]

Part of me wonders if we really want this interface: it seems kind of like we
could just use TestRenderFrameHost for unit tests, since this code lives in
//content.

(Not really something to tackle in this patch, just wondering aloud)

[dmazzoni, 2016/03/24 04:26:53]

Yeah, the current design is that BrowserAccessibilityManager doesn't actually
depend on RFHI, it defines this delegate interface and RFHI depends on it.

It does seem like we could reverse the dependency and have this class depend on
RFHI instead. It's really only this way for historical reasons and I can see
pros and cons of both ways.

Maybe that's not exactly what you were asking.

For unit tests it does seem like we could use TestRenderFrameHost instead.

[dcheng, 2016/03/24 04:33:14]

This is basically along the lines of what I was thinking, but it's definitely a
project for another patch (if we do it at all).

+  virtual SiteInstance* AccessibilityGetSiteInstance() = 0;
   virtual void AccessibilityHitTest(
       const gfx::Point& point) = 0;
   virtual void AccessibilitySetAccessibilityFocus(int acc_obj_id) = 0;
   virtual void AccessibilityFatalError() = 0;
   virtual gfx::AcceleratedWidget AccessibilityGetAcceleratedWidget() = 0;
   virtual gfx::NativeViewAccessible AccessibilityGetNativeViewAccessible() = 0;
 };
 
 class CONTENT_EXPORT BrowserAccessibilityFactory {
  public:
@@ skipping 316 matching lines @@
   // node within that parent tree. It's computed as needed and cached for
   // speed so that it can be accessed quickly if it hasn't changed.
   int parent_node_id_from_parent_tree_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_MANAGER_H_