content/test/data/accessibility/html/frame/nested-frame.html - Issue 1713723002: Implement accessibility support for CSS-transformed iframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/html/frame/nested-frame.html

Issue 1713723002: Implement accessibility support for CSS-transformed iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return gfx::Rect from AccessibilityTransformToRootCoordSpace, get rid of ifdefed-out code accidenta… Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/accessibility_tree_formatter_blink.cc ('K') | « content/test/data/accessibility/html/frame/box.html ('k') | content/test/data/accessibility/html/iframe-transform.html » ('j') | ui/accessibility/ax_node_data.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body style="padding: 0; margin: 0;">

	4 <iframe width=250 height=250 src="box.html" style="border: 0; position: absolu te; top: 0px; left: 100px; transform: scale(2.0); transform-origin: left top;">< /iframe>
	dcheng 2016/03/17 19:53:18 Can we make the nested frame cross-process as well Can we make the nested frame cross-process as well? I'm interested in seeing how the: a.com b.com c.com case works. I haven't managed to convince myself it works, because we always return immediately after consulting a cross-site parent (if necessary) for the transforms in BrowserAccessibility::ElementBoundsToLocalBounds. dcheng 2016/03/17 19:54:39 Reformatting for the sake of email: a.com `-b.com Show quoted text On 2016/03/17 at 19:53:18, dcheng wrote: > Can we make the nested frame cross-process as well? I'm interested in seeing how the: > > a.com > b.com > c.com > > case works. I haven't managed to convince myself it works, because we always return immediately after consulting a cross-site parent (if necessary) for the transforms in BrowserAccessibility::ElementBoundsToLocalBounds. Reformatting for the sake of email: a.com `-b.com `-c.com dmazzoni 2016/03/18 17:10:59 The case of nested local frames was wrong, but fix Show quoted text On 2016/03/17 19:53:18, dcheng wrote: > Can we make the nested frame cross-process as well? I'm interested in seeing how > the: > > a.com > b.com > c.com > > case works. I haven't managed to convince myself it works, because we always > return immediately after consulting a cross-site parent (if necessary) for the > transforms in BrowserAccessibility::ElementBoundsToLocalBounds. The case of nested local frames was wrong, but fixed now. Multiple remote frames returns immediately because the transformation done by RFHI correctly transforms a remote frame's coordinate space all the way back to the coordinate space of the WebContents, no matter how many nested frames there are. Either way, both are now tested. dmazzoni 2016/03/18 17:10:59 Yes, but I'll add a separate test for this. The re Show quoted text On 2016/03/17 19:54:39, dcheng wrote: > On 2016/03/17 at 19:53:18, dcheng wrote: > > Can we make the nested frame cross-process as well? I'm interested in seeing > how the: > > > > a.com > > b.com > > c.com > > > > case works. I haven't managed to convince myself it works, because we always > return immediately after consulting a cross-site parent (if necessary) for the > transforms in BrowserAccessibility::ElementBoundsToLocalBounds. > > > Reformatting for the sake of email: > a.com > `-b.com > `-c.com Yes, but I'll add a separate test for this. The remote -> local test was actually broken, but remote -> remote already passed.
	5 </body>

	6 </html>

OLD	NEW