Use unorm shorts for texture coordinates when rendering text.

Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

Committed: https://skia.googlesource.com/skia/+/7023a00c35d904e4ccff09c377e9ba26abba6181

[jvanverth1, 2016-02-18 19:59:48]

Description was changed from

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
==========

to

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-02-18 20:02:07]

jvanverth@google.com changed reviewers:
+ joshualitt@google.com

[jvanverth1, 2016-02-18 20:02:08]

As one might expect, there are some differences in the GMs, but they're not
visible -- at least, not on my Windows machine.

[joshualitt, 2016-02-18 20:12:12]

lgtm + question

https://codereview.chromium.org/1713693002/diff/1/src/gpu/GrBatchAtlas.h
File src/gpu/GrBatchAtlas.h (right):

https://codereview.chromium.org/1713693002/diff/1/src/gpu/GrBatchAtlas.h#newc...
src/gpu/GrBatchAtlas.h:24: int log2Height() const { return SkNextLog2(fHeight);
}
is it worth caching these?

[jvanverth1, 2016-02-18 20:21:20]

https://codereview.chromium.org/1713693002/diff/1/src/gpu/GrBatchAtlas.h
File src/gpu/GrBatchAtlas.h (right):

https://codereview.chromium.org/1713693002/diff/1/src/gpu/GrBatchAtlas.h#newc...
src/gpu/GrBatchAtlas.h:24: int log2Height() const { return SkNextLog2(fHeight);
}
On 2016/02/18 20:12:11, joshualitt wrote:
> is it worth caching these?

Yes, that makes sense.

[jvanverth1, 2016-02-19 14:01:03]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-02-19 14:01:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1713693002/#ps40001
(title: "Fix one maskformat")

[commit-bot: I haz the power, 2016-02-19 14:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713693002/40001

[commit-bot: I haz the power, 2016-02-19 14:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 14:04:08]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[jvanverth1, 2016-02-19 14:23:14]

Description was changed from

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com
==========

[jvanverth1, 2016-02-19 14:23:23]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-02-19 14:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713693002/40001

[commit-bot: I haz the power, 2016-02-19 14:35:26]

Description was changed from

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com
==========

to

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063
==========

[commit-bot: I haz the power, 2016-02-19 14:35:27]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

[jvanverth1, 2016-02-19 16:42:46]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1709133003/ by jvanverth@google.com.

The reason for reverting is: Causing issues with text on Mali 400s. Examples:
	largeglyphblur, imageblurtiled. It appears that there are precision problems. .

[jvanverth1, 2016-02-22 17:21:10]

Description was changed from

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063
==========

to

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063
==========

[jvanverth1, 2016-02-22 19:01:57]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-02-22 19:02:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
joshualitt@google.com
Link to the patchset: https://codereview.chromium.org/1713693002/#ps80001
(title: "Fix tabbing")

[commit-bot: I haz the power, 2016-02-22 19:02:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713693002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713693002/80001

[commit-bot: I haz the power, 2016-02-22 19:25:34]

Description was changed from

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063
==========

to

==========
Use unorm shorts for texture coordinates when rendering text.

There are a couple of reasons for this:
- Vulkan does not guarantee conversions from integral vertex attributes
  to floating point shader variables
- This may be faster and more precise on some platforms, as it avoids
  the aforementioned conversion and changes a multiply by a very small
  value to a multiply by a medium-sized value.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063

Committed:
https://skia.googlesource.com/skia/+/7023a00c35d904e4ccff09c377e9ba26abba6181
==========

[commit-bot: I haz the power, 2016-02-22 19:25:35]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/7023a00c35d904e4ccff09c377e9ba26abba6181