Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1713653002: make SkPM4f private (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
herb_g, mtklein, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : more files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -37 lines) Patch
M bench/SkLinearBitmapPipelineBench.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M bench/Xfer4fBench.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M bench/XferU64Bench.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gm/xfer4f.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/xfermodes.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/xferu64.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColor.h View 1 chunk +1 line, -33 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBlitter_PM4f.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorSpace.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkModeColorFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkPM4f.h View 1 chunk +46 lines, -0 lines 0 comments Download
M src/core/SkPM4fPriv.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPixmap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/Float16Test.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/SkColor4fTest.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/SkLinearBitmapPipelineTest.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
reed1
ptal
4 years, 10 months ago (2016-02-18 20:04:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713653002/20001
4 years, 10 months ago (2016-02-18 20:04:15 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/6290) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
4 years, 10 months ago (2016-02-18 20:05:28 UTC) #7
mtklein
lgtm
4 years, 10 months ago (2016-02-18 20:05:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713653002/40001
4 years, 10 months ago (2016-02-18 20:10:56 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 20:39:18 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dd9ffea9ce051a49dbc6544e6aa3cb68fe987f47

Powered by Google App Engine
This is Rietveld 408576698