cc: Make cc_unittests opt into real GL NullDraw contexts.

cc: Make cc_unittests opt into real GL NullDraw contexts.

This breaks the dependency on the TestCompositor for
this test suite. Once it's no longer in use by any test
suite, we can remove it.

Depends on: Depends on: https://codereview.chromium.org/175093004/

R=enne
BUG=270918
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252770

[enne (OOO), 2014-02-21 21:05:33]

lgtm+nits

https://codereview.chromium.org/171363008/diff/1/cc/test/cc_test_suite.cc
File cc/test/cc_test_suite.cc (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/cc_test_suite.cc#new...
cc/test/cc_test_suite.cc:21: gfx::GLSurface::InitializeOneOffForTests(true);
Can you name this boolean?

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_test.h
File cc/test/layer_tree_pixel_test.h (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_tes...
cc/test/layer_tree_pixel_test.h:99: scoped_ptr<gfx::DisableNullDrawGLBindings>
enable_pixel_output_;
Could this just be a member, or does it need to be initialized during SetupGL?

[danakj, 2014-02-21 21:08:31]

https://codereview.chromium.org/171363008/diff/1/cc/test/cc_test_suite.cc
File cc/test/cc_test_suite.cc (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/cc_test_suite.cc#new...
cc/test/cc_test_suite.cc:21: gfx::GLSurface::InitializeOneOffForTests(true);
On 2014/02/21 21:05:33, enne wrote:
> Can you name this boolean?

Oh, ok. It's going to go away as soon as all test suites pass true. I was going
for minimal churn as possible here.

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_test.h
File cc/test/layer_tree_pixel_test.h (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_tes...
cc/test/layer_tree_pixel_test.h:99: scoped_ptr<gfx::DisableNullDrawGLBindings>
enable_pixel_output_;
On 2014/02/21 21:05:33, enne wrote:
> Could this just be a member, or does it need to be initialized during SetupGL?

It means we'd toggle state in the GL bindings for software compositor tests.
Seemed weird to me. Wouldn't hurt tho. WDYT?

[enne (OOO), 2014-02-21 21:11:36]

https://codereview.chromium.org/171363008/diff/1/cc/test/cc_test_suite.cc
File cc/test/cc_test_suite.cc (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/cc_test_suite.cc#new...
cc/test/cc_test_suite.cc:21: gfx::GLSurface::InitializeOneOffForTests(true);
On 2014/02/21 21:08:31, danakj wrote:
> On 2014/02/21 21:05:33, enne wrote:
> > Can you name this boolean?
> 
> Oh, ok. It's going to go away as soon as all test suites pass true. I was
going
> for minimal churn as possible here.

sgtm

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_test.h
File cc/test/layer_tree_pixel_test.h (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_tes...
cc/test/layer_tree_pixel_test.h:99: scoped_ptr<gfx::DisableNullDrawGLBindings>
enable_pixel_output_;
On 2014/02/21 21:08:31, danakj wrote:
> On 2014/02/21 21:05:33, enne wrote:
> > Could this just be a member, or does it need to be initialized during
SetupGL?
> 
> It means we'd toggle state in the GL bindings for software compositor tests.
> Seemed weird to me. Wouldn't hurt tho. WDYT?

That is a little weird.  I could go either way.

[danakj, 2014-02-21 21:12:39]

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_test.h
File cc/test/layer_tree_pixel_test.h (right):

https://codereview.chromium.org/171363008/diff/1/cc/test/layer_tree_pixel_tes...
cc/test/layer_tree_pixel_test.h:99: scoped_ptr<gfx::DisableNullDrawGLBindings>
enable_pixel_output_;
On 2014/02/21 21:11:37, enne wrote:
> On 2014/02/21 21:08:31, danakj wrote:
> > On 2014/02/21 21:05:33, enne wrote:
> > > Could this just be a member, or does it need to be initialized during
> SetupGL?
> > 
> > It means we'd toggle state in the GL bindings for software compositor tests.
> > Seemed weird to me. Wouldn't hurt tho. WDYT?
> 
> That is a little weird.  I could go either way.

Well, I made the other one a simple member instead of a pointer. I think I
prefer to keep this one as it is tho.

[danakj, 2014-02-21 21:29:14]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-02-21 21:30:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/171363008/100001

[commit-bot: I haz the power, 2014-02-21 23:44:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 23:44:14]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[danakj, 2014-02-21 23:46:26]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-02-21 23:48:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/171363008/100001

[commit-bot: I haz the power, 2014-02-22 01:28:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/171363008/100001

[commit-bot: I haz the power, 2014-02-22 08:08:25]

Change committed as 252770