Store return types of variable initializers in summaries.

Store return types of variable initializers in summaries.

This required adding the ability to refer to the "bottom" type in
summaries.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/f7d3a6f76ee3b34d09343410fe24403799b247ef

[Paul Berry, 2016-02-18 17:55:31]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-18 18:11:44]

LGTM

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:379: return index;
Also maybe remove this statement and fall through.
AFAIK this would be closer to the "lazy initialization" pattern.

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1335: // inferred return type
slot should be empty.
Remove these two lines?

[Paul Berry, 2016-02-18 18:18:15]

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:379: return index;
On 2016/02/18 18:11:44, scheglov wrote:
> Also maybe remove this statement and fall through.
> AFAIK this would be closer to the "lazy initialization" pattern.

Good catch, thanks!  Fixed both here and in serializeUnresolvedReference(), and
I added tests which would have failed in the absence of these fixes.

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/summary_common.dart (right):

https://codereview.chromium.org/1713593002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/summary_common.dart:1335: // inferred return type
slot should be empty.
On 2016/02/18 18:11:44, scheglov wrote:
> Remove these two lines?

Done.

[Paul Berry, 2016-02-18 18:19:42]

Description was changed from

==========
Store return types of variable initializers in summaries.

This required adding the ability to refer to the "bottom" type in
summaries.
==========

to

==========
Store return types of variable initializers in summaries.

This required adding the ability to refer to the "bottom" type in
summaries.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f7d3a6f76ee3b34d09343410fe24403799b247ef
==========

[Paul Berry, 2016-02-18 18:19:43]

Committed patchset #1 (id:1) manually as
f7d3a6f76ee3b34d09343410fe24403799b247ef (presubmit successful).