Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 171353002: Fixing top-navigation in DCC (Closed)

Created:
6 years, 10 months ago by mkearney1
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fixing top-navigation in DCC Adding in full DCC content_providers.json Also slightly improving redirects. Note that this starts off with patch https://codereview.chromium.org/148663007/. Just made sense to deliver the content from this patch with restored navigation. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252143

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -1050 lines) Patch
M chrome/common/extensions/docs/server2/app.yaml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/api_index.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 2 3 4 5 12 chunks +656 lines, -22 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/content_providers.json View 1 2 2 chunks +40 lines, -40 lines 0 comments Download
D chrome/common/extensions/docs/templates/json/pending_sidenav.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -981 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/redirects.json View 1 2 3 4 5 6 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Renato Mangini (chromium)
As discussed in person, my suggestion is to, instead of having two entries for Chrome ...
6 years, 10 months ago (2014-02-18 23:53:32 UTC) #1
mkearney1
On 2014/02/18 23:53:32, Renato Mangini (chromium) wrote: > As discussed in person, my suggestion is ...
6 years, 10 months ago (2014-02-19 00:21:21 UTC) #2
not at google - send to devlin
can you kill the "pending_sidenav" file I added before, too? lgtm when renato is happy
6 years, 10 months ago (2014-02-19 00:22:21 UTC) #3
Renato Mangini (chromium)
lgtm
6 years, 10 months ago (2014-02-19 01:29:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/171353002/140001
6 years, 10 months ago (2014-02-19 01:54:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 02:19:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=50866
6 years, 10 months ago (2014-02-19 02:19:12 UTC) #7
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-19 03:29:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/171353002/310001
6 years, 10 months ago (2014-02-19 03:30:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 03:49:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-19 03:49:29 UTC) #11
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-19 08:04:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/171353002/310001
6 years, 10 months ago (2014-02-19 08:05:35 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 08:05:43 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-19 08:05:43 UTC) #15
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-19 15:45:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/171353002/310001
6 years, 10 months ago (2014-02-19 15:46:06 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 15:52:36 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel
6 years, 10 months ago (2014-02-19 15:52:37 UTC) #19
mkearney1
The CQ bit was checked by mkearney@chromium.org
6 years, 10 months ago (2014-02-20 00:01:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkearney@chromium.org/171353002/310001
6 years, 10 months ago (2014-02-20 00:14:49 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 01:29:30 UTC) #22
Message was sent while issue was closed.
Change committed as 252143

Powered by Google App Engine
This is Rietveld 408576698