Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1713513002: Rename -webkit-text to -internal-quirk-inherit, limiting it to UA style (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename -webkit-text to -internal-quirk-inherit, limiting it to UA style Stop accepting the -webkit-text value for color properties in quirks mode. Rename it to -internal-quirk-inherit to better match the naming in the quirks mode spec [1]. Usage of this property value is low [2]. [1] https://quirks.spec.whatwg.org/#the-tables-inherit-color-from-body-quirk [2] https://www.chromestatus.com/metrics/feature/timeline/popularity/942 BUG=586485 Committed: https://crrev.com/0c5a90dd11c7920192cb6170037fa70b40b840e5 Cr-Commit-Position: refs/heads/master@{#376506}

Patch Set 1 #

Patch Set 2 : Rebase; add new (negative) test #

Messages

Total messages: 14 (6 generated)
fs
4 years, 10 months ago (2016-02-19 13:04:25 UTC) #3
Timothy Loh
On 2016/02/19 13:04:25, fs wrote: lgtm!
4 years, 10 months ago (2016-02-19 13:11:21 UTC) #4
fs
On 2016/02/19 at 13:11:21, timloh wrote: > On 2016/02/19 13:04:25, fs wrote: > > lgtm! ...
4 years, 10 months ago (2016-02-19 13:18:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713513002/20001
4 years, 10 months ago (2016-02-19 13:20:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/25765)
4 years, 10 months ago (2016-02-19 15:40:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713513002/20001
4 years, 10 months ago (2016-02-19 18:55:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 19:07:06 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 19:07:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c5a90dd11c7920192cb6170037fa70b40b840e5
Cr-Commit-Position: refs/heads/master@{#376506}

Powered by Google App Engine
This is Rietveld 408576698